370: Mark as final #1641

pull achow101 wants to merge 2 commits into bitcoin:master from achow101:finalize-370 changing 2 files +4 −4
  1. achow101 commented at 11:08 pm on July 10, 2024: member
    BIP 370 is implemented by multiple software and should be Final.
  2. jonatack commented at 11:25 pm on July 10, 2024: contributor
    Should the reference implementation of this BIP be updated to https://github.com/bitcoin/bitcoin/pull/21283, and which software have adopted PSBT v2?
  3. achow101 commented at 0:43 am on July 11, 2024: member

    Should the reference implementation of this BIP be updated to bitcoin/bitcoin#21283,

    It’s the same thing, but sure.

    and which software have adopted PSBT v2?

    Off the top of my head, HWI and Ledger I know for sure.

    Anyways, I don’t think this BIP is going to change.

  4. achow101 force-pushed on Jul 11, 2024
  5. in bip-0370.mediawiki:500 in ea922a437e outdated
    496@@ -497,4 +497,4 @@ The timelock for the following PSBTs cannot be computed:
    497 
    498 ==Reference implementation==
    499 
    500-The reference implementation of the PSBT format is available at https://github.com/achow101/bitcoin/tree/psbt2.
    501+The reference implementation of the PSBT format is available at https://github.com/bitcoin/bitcoin/pull/21283.
    


    jonatack commented at 5:32 pm on July 11, 2024:

    Suggest this, or an equivalent, so the period isn’t counted as part of the link.

    0The reference implementation of the PSBT format is available at [https://github.com/bitcoin/bitcoin/pull/21283](https://github.com/bitcoin/bitcoin/pull/21283).
    

    achow101 commented at 6:26 pm on July 11, 2024:
    Made into a proper link.
  6. jonatack commented at 5:33 pm on July 11, 2024: contributor
    ACK, one nit
  7. achow101 force-pushed on Jul 11, 2024
  8. 370: Set reference implementation to Bitcoin Core PR. e7286a5356
  9. 370: Mark as final 968c4ee200
  10. achow101 force-pushed on Jul 11, 2024
  11. jonatack commented at 6:59 pm on July 11, 2024: contributor
    ACK, thanks for updating
  12. jonatack merged this on Jul 11, 2024
  13. jonatack closed this on Jul 11, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-11 06:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me