BIP-0094: Fix typo #1659

pull azuchi wants to merge 1 commits into bitcoin:master from azuchi:bix-bip94-typo changing 1 files +1 −1

azuchi commented at 5:05 AM on August 9, 2024: contributor

"block hex" -> "coinbase hex"
murchandamus commented at 3:50 PM on August 9, 2024: contributor

@fjahr: could you please take a look?

fjahr commented at 5:02 PM on August 9, 2024: contributor

Oh, I indeed pasted just the hex of the coinbase there without the header. Instead of fixing the typo we should add the full block hex. It should be this, then "block hex" is correct:

0100000000000000000000000000000000000000000000000000000000000000000000004e7b2b9128fe0291db0693af2ae418b767e657cd407e80cb1434221eaea7a07a046f3566ffff001dbb0c78170101000000010000000000000000000000000000000000000000000000000000000000000000ffffffff5504ffff001d01044c4c30332f4d61792f323032342030303030303030303030303030303030303030303165626435386332343439373062336161396437383362623030313031316662653865613865393865303065ffffffff0100f2052a010000002321000000000000000000000000000000000000000000000000000000000000000000ac00000000

Can you amend your PR @azuchi ? Thanks!

BIP-0094: fix block hex af9557b589
azuchi force-pushed on Aug 10, 2024
azuchi commented at 1:24 AM on August 10, 2024: contributor

@fjahr I fixed.
fjahr commented at 1:22 PM on August 10, 2024: contributor

ACK af9557b589df19508e1b6937346a4b9724bd90d8
jonatack merged this on Aug 11, 2024
jonatack closed this on Aug 11, 2024

Contributors

azuchi

murchandamus

fjahr