BIP39: update status from Proposed to Final

scgbckbone commented at 12:51 pm on October 5, 2024: contributor

also widely deployed

in bip-0039.mediawiki:11 in dd44aa588b outdated

 5@@ -6,9 +6,9 @@
 6           Pavol Rusnak <stick@satoshilabs.com>
 7           Aaron Voisine <voisine@gmail.com>
 8           Sean Bowe <ewillbefull@gmail.com>
 9-  Comments-Summary: Unanimously Discourage for implementation
10+  Comments-Summary: No comments yet.
11   Comments-URI: https://github.com/bitcoin/bips/wiki/Comments:BIP-0039
12-  Status: Proposed
13+  Status: Final

jonatack commented at 1:46 pm on October 5, 2024:

The CI is red because the README.md file needs to be updated as well.

in bip-0039.mediawiki:9 in dd44aa588b outdated

 5@@ -6,9 +6,9 @@
 6           Pavol Rusnak <stick@satoshilabs.com>
 7           Aaron Voisine <voisine@gmail.com>
 8           Sean Bowe <ewillbefull@gmail.com>
 9-  Comments-Summary: Unanimously Discourage for implementation
10+  Comments-Summary: No comments yet.

jonatack commented at 1:52 pm on October 5, 2024:

For context, the “Unanimously Discourage for implementation” assessment was added as part of a wider change in #500. Seems fine to update if out of date / community agrees. Correcting myself, it depends on the content of the comments wiki page as mentioned in #1413 (comment).

More info per BIP 2:

 0Summary tones may be chosen from the following, but this BIP does not intend to cover all possible nuances and other summaries may be used as needed:
 1
 2* No comments yet.
 3* Unanimously Recommended for implementation
 4* Unanimously Discourage for implementation
 5* Mostly Recommended for implementation, with some Discouragement
 6* Mostly Discouraged for implementation, with some Recommendation
 7
 8.../...
 9
10To avoid doubt: comments and status are unrelated metrics to judge a BIP, and neither should be directly influencing the other.

apoelstra commented at 2:23 pm on October 5, 2024:

Thanks for putting this clearly in the title of your PR, unlike the last attempt to remove this language #1413 (which I eventually had to find using git log --all).

But I don’t think you’ll get “community agreement” on deleting this language entirely.

jonatack commented at 2:30 pm on October 5, 2024:

@apoelstra thank you for the link to #1413 for more context.

scgbckbone commented at 2:45 pm on October 5, 2024:

But I don’t think you’ll get “community agreement” on deleting this language entirely.

even tho I agree to what is stated in #1413, I think the ship has already sailed and most of the wallets already implement it. “Unanimously Discourage for implementation” was therefore pointless back then and even more now.

If necessary, it would be better to add a Shortcomings(or similar) section to this BIP and “copy” the comment from #1413 which at least give reader some useful info, instead of just fuding with “Unanimously Discourage for implementation”

jonatack commented at 2:53 pm on October 5, 2024:

@scgbckbone I’ve edited my comments above. It may be a good idea to drop this here and discuss a change to the comment summary in a separate PR (assuming that updating the comment summary isn’t incompatible with a Final status), and/or add relevant expert review to the wiki.

If necessary, it would be better to add a Shortcomings(or similar) section to this BIP

Agree, i.e. per @apoelstra’s suggestions in #1413 (comment), perhaps best to do that before updating the BIP status to Final.

murchandamus commented at 7:12 pm on November 7, 2024:

While I agree that the comments feature of the existing BIP Process has failed to be meaningfully adopted, I don’t think this change is in line with the currently active process. I would agree with BIP 39 being moved to Final, but I would suggest that you defer the change regarding the comment summary until a new BIP Process is adopted that supports the removal (as e.g. the one that I have been working on would).

jonatack renamed this:
~~change BIP39 status to Final and remove discourage comment~~
BIP39: update status to Final, remove discourage comment summary
on Oct 5, 2024

scgbckbone force-pushed on Oct 5, 2024

jonatack added the label Proposed BIP modification on Oct 5, 2024

jonatack commented at 2:20 pm on October 5, 2024: member

cc BIP author @prusnak

katesalazar commented at 9:11 am on October 6, 2024: contributor

NAK to changes out of process

prusnak commented at 7:40 pm on October 6, 2024: contributor

Honestly, I could not care less what this repository says for this BIP. Reality is that literally all hardware wallets and vast majority of software wallets use BIP39.

The BIP process back in the days was a disaster. We were forced to add certain features to the BIP (which we did not like) to satisfy the reviewers, then they said they did not like the changes anyway and they will not recommend using it. All this negative feedback happened more than a half a year ago after we started to use BIP39 in Trezor, so we could not do any further changes.

I recommend all wallets to consider using SLIP39 which has better wordlist, better checksum and can generate shamir secret shares. The only drawback is that the backup is now 20 words instead of 12 (for 128 bit of entropy).

murchandamus changes_requested

murchandamus added the label PR Author action required on Nov 7, 2024

change BIP39 status to Final 829afccd1a

scgbckbone force-pushed on Nov 8, 2024

scgbckbone commented at 10:37 am on November 8, 2024: contributor

I’ve reverted the comment back & rebased. Moving to final is “good enough” for now.

jonatack renamed this:
~~BIP39: update status to Final, remove discourage comment summary~~
BIP39: update status from Proposed to Final
on Nov 8, 2024

jonatack commented at 3:10 pm on November 8, 2024: member

ACK 829afccd1ae26403f8c3583d7347b04aeb54c2ca

jonatack removed the label PR Author action required on Nov 8, 2024

jonatack requested review from murchandamus on Nov 8, 2024

murchandamus approved

murchandamus commented at 5:22 pm on November 8, 2024: contributor

ACK 829afccd1ae26403f8c3583d7347b04aeb54c2ca

murchandamus merged this on Nov 8, 2024

murchandamus closed this on Nov 8, 2024

katesalazar commented at 9:15 pm on November 9, 2024: contributor

ACK 829afccd1ae26403f8c3583d7347b04aeb54c2ca

witaliy12 approved

BIP39: update status from Proposed to Final #1677