- Address lingering feedback from #1679
- Complete words table for application 39’ (I could bump to semver 1.4.0. for this but that seems excessive)
- Reorder sections to be more standard
- Convert discussion to standard footnote
BIP-85: formatting and changelog updates, and add word cases for application 39' #1691
pull akarve wants to merge 4 commits into bitcoin:master from akarve:bip85-details changing 1 files +36 −28-
akarve commented at 7:13 pm on October 25, 2024: contributor
-
BIP-85: Rename to 'changelog' and move above Reference implementation(s) e0cc4f0e3d
-
BIP-85: Add 15 and 21 word entries to application 39' table 9133ab2451
-
in bip-0085.mediawiki:210 in 9133ab2451 outdated
205 | 18' 206 |- 207+| 21 words 208+| 224 bits 209+| 21' 210+|-
jonatack commented at 8:39 pm on October 26, 2024:In 9133ab2451c4d78631eb10bbd73ec23fd8b31a83 lgtm, these reflect the table in BIP39 “Generating the mnemonic” sectionin bip-0085.mediawiki:98 in 9133ab2451 outdated
94@@ -95,7 +95,36 @@ OUTPUT 95 96 * DRNG(80 bytes)=b78b1ee6b345eae6836c2d53d33c64cdaf9a696487be81b03e822dc84b3f1cd883d7559e53d175f243e4c349e822a957bbff9224bc5dde9492ef54e8a439f6bc8c7355b87a925a37ee405a7502991111 97 98-==Reference Implementation== 99+==Changelog==
jonatack commented at 8:47 pm on October 26, 2024:In e0cc4f0e3d3657b025af318de009f6028d673211, maybe more or less follow the following order, per that of other BIPs:
- Abstract
- Copyright
- Definitions / Motivation
…/…
- References
- Reference Implementation
- Changelog
- Footnotes
- Acknowledgements
akarve commented at 3:59 pm on November 8, 2024:Sounds reasonable. Will put something together over the weekend.jonatack commented at 8:48 pm on October 26, 2024: memberConcept ACKjonatack added the label PR Author action required on Nov 7, 2024BIP-85: Reorder sections to be more standard, convert HMAC discussion to footnote 88f4fc0eceakarve requested review from jonatack on Nov 9, 2024BIP-85: Move new reference to be near HMAC code b398219e9cjonatack removed the label PR Author action required on Nov 14, 2024jonatack added the label Proposed BIP modification on Nov 14, 2024jonatack commented at 2:20 am on November 14, 2024: memberACK b398219e9cf23b66431debda13765f6557e98239
Only changes are presentation/formatting and adding two entries to the application 39’ table.
jonatack renamed this:
BIP-85: Move and reorder changelog to be near implementations, note 15' and 21' word cases for application 39'
BIP-85: formatting and changelog updates, and add word cases for application 39'
on Nov 14, 2024jonatack merged this on Nov 14, 2024jonatack closed this on Nov 14, 2024
akarve deleted the branch on Nov 14, 2024bitcoin deleted a comment on Nov 14, 2024bitcoin deleted a comment on Nov 14, 2024
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 09:10 UTC
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 09:10 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me