Fix wrong test vector in BIP-388. Sometimes /<0;1>/* is missing. Sometimes it is incorrectly written as <0,1>. #1694

pull pad01g wants to merge 1 commits into bitcoin:master from pad01g:bip-388-test-vectors-valid-policies changing 1 files +8 −9

pad01g commented at 9:27 AM on November 5, 2024: contributor

I found that test vectors in BIP-388 contain errors regarding multipath descriptor derivation. Also, fixed invalid newline in multipath descriptor derivation doc.
fix wrong test vector. sometimes /<0;1>/* is missing. sometimes incorrectly written as <0,1>. dcb140a865
pad01g marked this as ready for review on Nov 5, 2024
jonatack added the label Proposed BIP modification on Nov 5, 2024
jonatack added the label Pending acceptance on Nov 5, 2024
jonatack commented at 6:05 PM on November 5, 2024: member

cc BIP author @bigspider
bigspider commented at 8:38 AM on November 6, 2024: contributor

ACK

Thanks for the fix, @pad01g!
jonatack removed the label Pending acceptance on Nov 6, 2024
jonatack commented at 7:25 PM on November 7, 2024: member

ACK
jonatack merged this on Nov 7, 2024
jonatack closed this on Nov 7, 2024
jonatack added the label Bug fix on Nov 8, 2024
jonatack removed the label Proposed BIP modification on Nov 8, 2024
pad01g deleted the branch on Dec 13, 2024

Contributors

Labels