[BIP-373] Slight rewrite of evenness byte footnote for clarity

kdmukai commented at 8:04 pm on December 16, 2024: contributor

Per discussion with @jonatack here: #1705 (review)

in bip-0373.mediawiki:59 in be81c8a1a1 outdated

57-need to include the evenness. Furthermore, PSBT_IN_TAP_BIP32_DERIVATION fields include fingerprints
58+BIP 32 public keys can be derived from a BIP 327 MuSig2 aggregate public key (see: [[bip-0328.mediawiki|BIP 328]]).
59+But since BIP 32 requires public keys to include their evenness byte, BIP 327 MuSig2 aggregate public keys must
60+include their evenness byte as well.
61+
62+Furthermore, PSBT_IN_TAP_BIP32_DERIVATION fields include fingerprints

jonatack commented at 8:08 pm on December 16, 2024:

Not sure about adding the inoperative newlines within this footnote, feel free to ignore.

kdmukai commented at 8:17 pm on December 16, 2024:

Wasn’t sure which was preferred: making space to preserve the unedited text (easiest diff to review) or reformatting/reflowing the entire paragraph with new line breaks (nicest final form).

achow101 commented at 10:47 pm on December 16, 2024:

The extra blank line does not render as a paragraph break, if that was what was intended.

jonatack commented at 1:40 pm on December 17, 2024:

Yes, probably clearer not to add them.

kdmukai commented at 2:06 pm on December 17, 2024:

Updated to remove invisible paragraph break.
Raw text reflowed to fit within 120 col width to be more tidy (even though has no impact on how it’s actually rendered).

jonatack commented at 8:12 pm on December 16, 2024: member

ACK be81c8a1a11e083475f27ed1db77fcec969bd01e

jonatack added the label Proposed BIP modification on Dec 16, 2024

jonatack requested review from achow101 on Dec 16, 2024

jonatack removed the label Proposed BIP modification on Dec 17, 2024

in bip-0373.mediawiki:60 in be81c8a1a1 outdated

58+BIP 32 public keys can be derived from a BIP 327 MuSig2 aggregate public key (see: [[bip-0328.mediawiki|BIP 328]]).
59+But since BIP 32 requires public keys to include their evenness byte, BIP 327 MuSig2 aggregate public keys must
60+include their evenness byte as well.
61+
62+Furthermore, PSBT_IN_TAP_BIP32_DERIVATION fields include fingerprints
63 to identify master keys, and these fingerprints require y-coordinate of the public key,

jonatack commented at 1:38 pm on December 17, 2024:

While here can do this as well #1705 (review)

0to identify master keys, and these fingerprints require the y-coordinate of the public key,

kdmukai commented at 2:06 pm on December 17, 2024:

Missing “the” added.

Slight rewrite of evenness byte explanation for clarity 45e626feab

kdmukai force-pushed on Dec 17, 2024

in bip-0373.mediawiki:61 in 45e626feab

67+But since BIP 32 requires public keys to include their evenness byte, BIP 327 MuSig2 aggregate public keys must
68+include their evenness byte as well. Furthermore, PSBT_IN_TAP_BIP32_DERIVATION fields include fingerprints to identify
69+master keys, and these fingerprints require the y-coordinate of the public key, so x-only serialization can't be used.
70+By including the aggregate key as a full public key, signers that are unaware of the MuSig2 outside of the PSBT will
71+still be able to identify which keys are derived from the aggregate key by computing and then comparing the
72+fingerprints. This is necessary for the signer to apply the correct tweaks to their partial signature.</ref> from the

jonatack commented at 2:47 pm on December 17, 2024:

@kdmukai while here, do you think “This” is unambiguous enough, or could it be clearer?

kdmukai commented at 7:44 pm on December 17, 2024:

I think it’s clear enough, though that detail is getting too far beyond my expertise so it’s inherently word-soupy to me (i.e. it’s a “me” problem, not a text problem).

jonatack commented at 2:49 pm on December 17, 2024: member

ACK overall change 45e626feab08d80093f622c9c2441bc127cf14c0 and review of git diff be81c8a 45e626f

jonatack merged this on Dec 17, 2024

jonatack closed this on Dec 17, 2024

achow101 commented at 10:11 pm on December 18, 2024: member

Post merge ACK

If you’re going to request my review, please at least let me review it before merging.

[BIP-373] Slight rewrite of evenness byte footnote for clarity #1717