BIP158: fix btcutil gcs broken link. #1726

pull epysqyli wants to merge 1 commits into bitcoin:master from epysqyli:patch-1 changing 1 files +1 −1

epysqyli commented at 11:14 PM on December 18, 2024: contributor

https://github.com/btcsuite/btcutil/blob/master/gcs leads to a broken link. I'm assuming the correct replacement is at https://github.com/btcsuite/btcd/tree/master/btcutil/gcs since btcutil is a sub-package in btcd, as stated in https://github.com/btcsuite/btcutil/tree/master?tab=readme-ov-file

BIP158: fix btcutil gcs broken link.

https://github.com/btcsuite/btcutil/blob/master/gcs leads to a broken link. I'm assuming the correct replacement is at https://github.com/btcsuite/btcd/tree/master/btcutil/gcs since `btcutil` is a sub-package in `btcd`, as stated in https://github.com/btcsuite/btcutil/tree/master?tab=readme-ov-file

9815147ab6

in bip-0158.mediawiki:347 in 9815147ab6

 343 | @@ -344,7 +344,7 @@ Light client: [https://github.com/lightninglabs/neutrino]
 344 |  
 345 |  Full-node indexing: https://github.com/Roasbeef/btcd/tree/segwit-cbf
 346 |  
 347 | -Golomb-Rice Coded sets: https://github.com/btcsuite/btcutil/blob/master/gcs
 348 | +Golomb-Rice Coded sets: https://github.com/btcsuite/btcd/tree/master/btcutil/gcs

jonatack commented at 11:47 PM on December 18, 2024:

LGTM. Per https://github.com/btcsuite/btcutil/tree/master, "This package is now a sub-package in the btcutil directory of the btcd repository."

jonatack commented at 11:48 PM on December 18, 2024: member

ACK, pinging BIP author and editor @Roasbeef for feedback.
jonatack assigned Roasbeef on Dec 18, 2024
murchandamus added the label Proposed BIP modification on Dec 19, 2024
murchandamus added the label Pending acceptance on Dec 19, 2024
murchandamus added the label Bug fix on Dec 19, 2024
jonatack unassigned Roasbeef on Jan 4, 2025
jonatack removed the label Pending acceptance on Jan 4, 2025
jonatack commented at 4:58 AM on January 4, 2025: member

On the basis that a working link that looks correct is preferable to a broken one, and that this minor change probably isn't worth the BIP author's review time (I messaged @Roasbeef privately in addition to here), let's go ahead and merge this. The link can be easily revised later if needed.
jonatack merged this on Jan 4, 2025
jonatack closed this on Jan 4, 2025
epysqyli deleted the branch on Jan 4, 2025

Contributors

epysqyli

jonatack

Labels

Proposed BIP modification Bug fix