[BIP-0349] OP_INTERNALKEY add credit section #1728

pull JeremyRubin wants to merge 2 commits into bitcoin:master from JeremyRubin:patch-11 changing 1 files +5 −1
  1. JeremyRubin commented at 4:52 am on December 20, 2024: contributor
  2. [BIP0-0349] OP_INTERNALKEY add credit section b02d2db586
  3. jonatack added the label Proposed BIP modification on Dec 20, 2024
  4. in bip-0349.md:67 in b02d2db586 outdated
    60@@ -61,7 +61,11 @@ TBD
    61 
    62 ## Credits
    63 
    64-TODO
    65+The concept for INTERNALKEY first arose in a discussion between Russell O'Connor
    66+and Jeremy Rubin in Bitcoin Wizards IRC, inspired by BIP-0118's key punning technique
    67+for the internal key https://gnusha.org/bitcoin-wizards/2022-01-05.log . It was later
    68+drafted into this BIP by Brandon Black.
    


    murchandamus commented at 2:05 pm on December 20, 2024:

    Maybe fold the link into the text:

    0The concept for INTERNALKEY first arose in a [discussion](https://gnusha.org/bitcoin-wizards/2022-01-05.log) between Russell O'Connor
    1and Jeremy Rubin in Bitcoin Wizards IRC, inspired by BIP-0118's key punning technique
    2for the internal key. It was later
    3drafted into this BIP by Brandon Black.
    
  5. murchandamus commented at 2:05 pm on December 20, 2024: contributor
    Otherwise, LGTM. cc: @reardencode
  6. reardencode commented at 2:25 pm on December 20, 2024: contributor
    Ack
  7. [BIP-0349] wrap discussion link
    Co-authored-by: Mark "Murch" Erhardt <murch@murch.one>
    d3d34c04f3
  8. murchandamus merged this on Dec 23, 2024
  9. murchandamus closed this on Dec 23, 2024

  10. JeremyRubin deleted the branch on Dec 23, 2024
  11. murchandamus removed the label Proposed BIP modification on Dec 27, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-01-21 07:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me