[BIP-0349] OP_INTERNALKEY add credit section #1728

pull JeremyRubin wants to merge 2 commits into bitcoin:master from JeremyRubin:patch-11 changing 1 files +5 −1

JeremyRubin commented at 4:52 AM on December 20, 2024: contributor

No description provided.
[BIP0-0349] OP_INTERNALKEY add credit section b02d2db586
jonatack added the label Proposed BIP modification on Dec 20, 2024

in bip-0349.md:67 in b02d2db586 outdated

  60 | @@ -61,7 +61,11 @@ TBD
  61 |  
  62 |  ## Credits
  63 |  
  64 | -TODO
  65 | +The concept for INTERNALKEY first arose in a discussion between Russell O'Connor
  66 | +and Jeremy Rubin in Bitcoin Wizards IRC, inspired by BIP-0118's key punning technique
  67 | +for the internal key https://gnusha.org/bitcoin-wizards/2022-01-05.log . It was later
  68 | +drafted into this BIP by Brandon Black.

murchandamus commented at 2:05 PM on December 20, 2024:

Maybe fold the link into the text:

The concept for INTERNALKEY first arose in a [discussion](https://gnusha.org/bitcoin-wizards/2022-01-05.log) between Russell O'Connor
and Jeremy Rubin in Bitcoin Wizards IRC, inspired by BIP-0118's key punning technique
for the internal key. It was later
drafted into this BIP by Brandon Black.

murchandamus commented at 2:05 PM on December 20, 2024: contributor

Otherwise, LGTM. cc: @reardencode
reardencode commented at 2:25 PM on December 20, 2024: contributor

Ack

[BIP-0349] wrap discussion link

Co-authored-by: Mark "Murch" Erhardt <murch@murch.one>

d3d34c04f3

murchandamus merged this on Dec 23, 2024
murchandamus closed this on Dec 23, 2024
JeremyRubin deleted the branch on Dec 23, 2024
murchandamus removed the label Proposed BIP modification on Dec 27, 2024

Contributors

JeremyRubin

murchandamus

reardencode