Update bip-0345.mediawiki #1742
pull Gudnessuche wants to merge 1 commits into bitcoin:master from Gudnessuche:patch-9 changing 1 files +2 −2-
Gudnessuche commented at 5:55 pm on January 7, 2025: contributorGrammatical errors made to make reading easily digestible.
-
Update bip-0345.mediawiki
Grammatical errors made to make reading easily digestible.
-
in bip-0345.mediawiki:84 in 9cc8b275ca
80@@ -81,7 +81,7 @@ Institutional custodians of Bitcoin may use vaults in similar fashion. 81 82 This proposal provides a mitigation to the 83 [https://web.archive.org/web/20230210123933/https://xkcd.com/538/ "$5 wrench attack."] By 84-setting the spend delay to, say, a week, and using as the recovery path a 85+setting the spend delay to, say, a week, and using as the recovery path, a
jonatack commented at 9:04 pm on January 7, 2025:This change doesn’t appear to be grammatically correct.jonatack commented at 9:15 pm on January 7, 2025: memberClosing, as this pull does not provide sufficient value to be worth valuable and scarce review time, is partially incorrect, and adds unneeded noise for subscribers to this repository and time requests for maintainers of this repository.
Rather than opening pull requests like this, may I suggest focusing efforts on:
- Updating already open PRs like #1737 in response to review feedback
- Opening PRs that provide more value
- Reviewing PRs by other contributors, which can be the best way to learn, improve, and add value. Please see this article for more information: https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core
jonatack closed this on Jan 7, 2025
Gudnessuche commented at 8:58 am on January 8, 2025: contributorsincerest appreciation @jonatack for sharing your article. I have gone through it, and I must say, it’s really eye opening. Would avoid nits from now on, and keep review more PRs than opening. God bless you.
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-01-21 07:10 UTC
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-01-21 07:10 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me