BIP345: fix OP_SUCCESS188 hex value #1745

pull shesek wants to merge 1 commits into bitcoin:master from shesek:patch-2 changing 1 files +1 −1

shesek commented at 4:12 AM on January 11, 2025: contributor

OP_SUCCESS188 is 0xbc, not 0xbb.
Fix typo in BIP 345
`OP_SUCCESS188` is `0xbc`, not `0xbb`.
c532b53ca2
jonatack added the label Bug fix on Jan 11, 2025
jonatack approved
jonatack commented at 5:59 PM on January 11, 2025: member

ACK c532b53ca2bfc4fbcf9a8d8e45c061db7ee8ce54, OP_SUCCESS188 is constrained with new rules in this BIP to implement OP_VAULT_RECOVER and 188 is 0xbc.
jonatack commented at 6:01 PM on January 11, 2025: member

Pinging @jamesob and @instagibbs for approval.
jonatack added the label Pending acceptance on Jan 11, 2025
Scutua approved
jonatack renamed this:
~~Fix typo in BIP 345~~
Fix OP_SUCCESS188 hex vslue of typo in BIP 345
on Jan 12, 2025
jonatack renamed this:
~~Fix OP_SUCCESS188 hex vslue of typo in BIP 345~~
BIP345: fix OP_SUCCESS188 hex value
on Jan 12, 2025
murchandamus approved
murchandamus commented at 7:48 PM on January 13, 2025: contributor

I was wondering whether it was obvious whether OP_SUCCESS187 was meant and 0xbb was correct, or whether OP_SUCCESS188 was correct and 0xbc was the typo.

As the line corrected in this PR follows another prior mention that introduces the two new opcodes, and the introductions of the paragraphs repeat except in the opcode name, it seems clear that the lower mention is a copy error from the previous header, and I agree that that this is correct.

The tapscript opcodes <code>OP_SUCCESS187</code> (<code>0xbb</code>) and <code>OP_SUCCESS188</code> (<code>0xbc</code>) are constrained with new rules to implement <code>OP_VAULT</code> and <code>OP_VAULT_RECOVER</code>, respectively.
murchandamus commented at 7:52 PM on January 13, 2025: contributor

The reference implementation also confirms this interpretation:

Merging.
murchandamus merged this on Jan 13, 2025
murchandamus closed this on Jan 13, 2025
jonatack removed the label Pending acceptance on Jan 13, 2025
bitcoin deleted a comment on Jan 15, 2025
bitcoin deleted a comment on Jan 15, 2025

Contributors

Labels