return was being used incorrectly to handle an exception. Instead of returning the exception, it should be raised using raise.
BIP388: Fix incorrect use of return for raising exception #1752
pull brawncode wants to merge 1 commits into bitcoin:master from brawncode:patch-1 changing 1 files +1 −1-
brawncode commented at 7:50 PM on January 25, 2025: contributor
-
fix: Fix incorrect use of return for raising exceptions Update wallet_policies.py 607cac148e
- Mohamezezo approved
- jonatack approved
-
jonatack commented at 6:19 PM on January 29, 2025: member
ACK 607cac148e7ca9a22a7784b481d464d894b94623
This is the only exception of 7 present in this file that is not raised, and without a reason for it that I can see.
-
jonatack commented at 6:20 PM on January 29, 2025: member
Pinging @bigspider for approval just in case.
- bigspider approved
-
bigspider commented at 6:25 PM on January 29, 2025: contributor
Thanks for the fix!
- jonatack renamed this:
fix: Fix incorrect use of return for raising exceptions Update wallet…
BIP388: Fix incorrect use of return for raising exception
on Jan 29, 2025 - jonatack merged this on Jan 29, 2025
- jonatack closed this on Jan 29, 2025
Contributors
