The sentence regarding empty byte arrays being used to indicate an invalid ECDSA signature is confusing. I attempted to make it clearer. If I screwed it up or can make it even clearer, please let me know.
Thank you.
Minor grammatical change #176
pull droark wants to merge 1 commits into bitcoin:master from droark:patch-2 changing 1 files +1 −1-
droark commented at 1:41 AM on July 29, 2015: contributor
-
ec575baa55
Minor grammatical change
The sentence regarding allowing empty byte arrays to indicate an invalid ECDSA signature is confusing. I attempted to make it clearer. If I screwed it up or can make it even clearer, please let me know. Thank you.
-
jonasschnelli commented at 7:02 AM on July 29, 2015: contributor
Please open trivial, non change PR at trivial next from @theuni: https://github.com/theuni/bitcoin/tree/trivial-next -
fanquake commented at 7:05 AM on July 29, 2015: member
@jonasschnelli This is the bips repo
-
jonasschnelli commented at 7:06 AM on July 29, 2015: contributor
Aii.. Ignore my comment then. Sorry.
-
laanwj commented at 6:40 PM on August 24, 2015: member
Don't feel strongly about it but "the empty byte array" is strictly correct. There is only one possible empty byte array.
-
droark commented at 3:54 PM on August 25, 2015: contributor
@laanwj - Sorry if my comment wasn't totally clear. I mentioned the empty byte array because that was, to me, the most unique phrase in the affected sentence. (Granted, I think "empty byte array" still sounds weird, but I won't rewrite that.) I've highlighted the differences below. In particular, "for with" is definitely a typo.
Original: "To provide a compact way to deliberately create an invalid signature for with OP_CHECKSIG and OP_CHECKMULTISIG the empty byte array (the result of OP_0) is also allowed."
Revision: "To provide a compact way to deliberately create an invalid signature for OP_CHECKSIG and OP_CHECKMULTISIG, an empty byte array (i.e., the result of OP_0) is also allowed."
-
-
sipa commented at 10:50 PM on September 3, 2015: member
ACK
- luke-jr referenced this in commit 7b19058197 on Sep 3, 2015
- luke-jr merged this on Sep 3, 2015
- luke-jr closed this on Sep 3, 2015
- luke-jr referenced this in commit 3a359c8e1e on Jun 6, 2017
- pinheadmz referenced this in commit cb1cec770b on Dec 15, 2019
