328: test vectors, reference implementation, update to Proposed #1762

1. 
   achow101 commented at 8:04 pm on February 11, 2025: member
2. 328: Add test vectors 081aa9a22e
3. achow101 force-pushed on Feb 11, 2025
4. achow101 renamed this:
   328: Add test vectors
   328: Add test vectors and reference implementation
   on Feb 11, 2025
5. achow101 force-pushed on Feb 11, 2025
6. 328: Add reference implementation 7ab43ce11f
7. achow101 force-pushed on Feb 11, 2025
8. 
   murchandamus commented at 4:50 pm on February 12, 2025: contributor

   Looks good. Would you please also update the “Created” field to 2024-06-04? According to BIP 2, the Created header refers to the date that a number is assigned?

   If you are updating this document anyway, would you like to move it to the “Proposed” status, now that all parts are present?

9. murchandamus added the label Proposed BIP modification on Feb 12, 2025
10. murchandamus added the label PR Author action required on Feb 12, 2025
11. 328: Correct Created date

    Date that the BIP number was assigned is 2024-06-04.

    3827648acc
12. 
    achow101 commented at 6:01 pm on February 12, 2025: member

    Done both.
13. in bip-0328.mediawiki:8 in 4a1837016a outdated

    4@@ -5,7 +5,7 @@
    5   Author: Ava Chow <me@achow101.com>
    6   Comments-Summary: No comments yet.
    7   Comments-URI: https://github.com/bitcoin/bips/wiki/Comments:BIP-0328
    8-  Status: Draft
    9+  Status: Proposed
    

    ---

    ---

    

    jonatack commented at 6:35 pm on February 13, 2025:

    In commit 4a1837016a57608795f936da98ff91ce316dc800, also update the README status and formatting (Needs +> |- style=“background-color: #ffffcf”)

    ---

    

    murchandamus commented at 2:27 pm on February 14, 2025:

    Fixed this
14. 
    jonatack commented at 6:36 pm on February 13, 2025: member

    ACK 4a1837016a57608795f936da98ff91ce316dc800 modulo README update
15. murchandamus force-pushed on Feb 13, 2025
16. jonatack renamed this:
    328: Add test vectors and reference implementation
    328: test vectors, reference implementation, update to Proposed
    on Feb 13, 2025
17. jonatack removed the label PR Author action required on Feb 13, 2025
18. 
    jonatack commented at 9:25 pm on February 13, 2025: member

    nit, maybe squash the last 2 commits
19. 328: Draft -> Proposed 151ec96c83
20. murchandamus force-pushed on Feb 14, 2025
21. 
    murchandamus commented at 2:28 pm on February 14, 2025: contributor

    Squashed the two commits that update to Proposed and fix the README accordingly into one commit.

    ACK 151ec96c83b4c59453c553f49cf3183fbb9176b4

22. murchandamus merged this on Feb 14, 2025
23. murchandamus closed this on Feb 14, 2025

    ---

Contributors
achow101 murchandamus jonatack

Labels
Proposed BIP modification