373: test vectors, reference implementation, update to Proposed #1764

1. 
   achow101 commented at 0:44 am on February 12, 2025: member
2. 373: Add test vectors 88f40411b1
3. 373: Add reference implementation 4e335af8bc
4. murchandamus added the label Proposed BIP modification on Feb 12, 2025
5. 
   jonatack commented at 6:41 pm on February 13, 2025: member

   utACK 4e335af8bca03145c93b810ee30c1fdde5dd3e41
6. 
   murchandamus commented at 8:26 pm on February 13, 2025: contributor

   Ah, could you also update the Created date here to 2024-06-04
7. 373: Correct Created date cf948d47a0
8. 373: Draft -> Proposed 3adf43df82
9. 
   achow101 commented at 8:52 pm on February 13, 2025: member

   Ah, could you also update the Created date here to 2024-06-04

   Done.

   Also marking it as proposed.

10. jonatack renamed this:
    373: test vectors and reference implementation
    373: test vectors, reference implementation, update to Proposed
    on Feb 13, 2025
11. 
    murchandamus commented at 2:24 pm on February 14, 2025: contributor

    LGTM, ACK 3adf43df82a7659c1734ce552917daf8b429bb24
12. murchandamus merged this on Feb 14, 2025
13. murchandamus closed this on Feb 14, 2025

    ---

14. 
    theStack commented at 11:08 pm on February 16, 2025: contributor

    How were these test vectors generated? There are apparently two instances where the “Bytes in Hex”/“Base 64 String” data doesn’t match (if my script is not buggy):

    0$ git clone -b bip373_vectors_verify https://github.com/theStack/bips bips_373_verify
    1$ cd bips_373_verify
    2$ ./analyze_bip373_vectors.py
    3!!! PSBT Bytes/Base64 mismatch for test vector '** With all pubnonces' (lines 226-227) !!!
    4!!! PSBT Bytes/Base64 mismatch for test vector '* Case: PSBT with x-only aggregate pubkey in output participant pubkeys keydata' (lines 268-270) !!!
    

    (Arrived here through reviewing https://github.com/bitcoin/bitcoin/pull/31247, looking at the test vector data and seeing that the “PSBT with x-only aggregate pubkey in output participant pubkeys keydata” case base64 data looks way too short)

15. 
    achow101 commented at 2:14 am on February 17, 2025: member

    How were these test vectors generated?

    By hand, the hard way. It’s possible there are copy-paste errors.

16. achow101 referenced this in commit 529a0458d8 on Feb 17, 2025

Contributors
achow101 jonatack murchandamus theStack

Labels
Proposed BIP modification