373: test vectors, reference implementation, update to Proposed #1764

pull achow101 wants to merge 4 commits into bitcoin:master from achow101:373-tests changing 2 files +95 −6

achow101 commented at 12:44 AM on February 12, 2025: member

No description provided.
373: Add test vectors 88f40411b1
373: Add reference implementation 4e335af8bc
murchandamus added the label Proposed BIP modification on Feb 12, 2025
jonatack commented at 6:41 PM on February 13, 2025: member

utACK 4e335af8bca03145c93b810ee30c1fdde5dd3e41
murchandamus commented at 8:26 PM on February 13, 2025: contributor

Ah, could you also update the Created date here to 2024-06-04
373: Correct Created date cf948d47a0
373: Draft -> Proposed 3adf43df82
achow101 commented at 8:52 PM on February 13, 2025: member

Ah, could you also update the Created date here to 2024-06-04

Done.

Also marking it as proposed.
jonatack renamed this:
~~373: test vectors and reference implementation~~
373: test vectors, reference implementation, update to Proposed
on Feb 13, 2025
murchandamus commented at 2:24 PM on February 14, 2025: contributor

LGTM, ACK 3adf43df82a7659c1734ce552917daf8b429bb24
murchandamus merged this on Feb 14, 2025
murchandamus closed this on Feb 14, 2025
theStack commented at 11:08 PM on February 16, 2025: contributor
How were these test vectors generated? There are apparently two instances where the "Bytes in Hex"/"Base 64 String" data doesn't match (if my script is not buggy):
```
$ git clone -b bip373_vectors_verify https://github.com/theStack/bips bips_373_verify
$ cd bips_373_verify
$ ./analyze_bip373_vectors.py
!!! PSBT Bytes/Base64 mismatch for test vector '** With all pubnonces' (lines 226-227) !!!
!!! PSBT Bytes/Base64 mismatch for test vector '* Case: PSBT with x-only aggregate pubkey in output participant pubkeys keydata' (lines 268-270) !!!
```
(Arrived here through reviewing https://github.com/bitcoin/bitcoin/pull/31247, looking at the test vector data and seeing that the "PSBT with x-only aggregate pubkey in output participant pubkeys keydata" case base64 data looks way too short)
achow101 commented at 2:14 AM on February 17, 2025: member

How were these test vectors generated?

By hand, the hard way. It's possible there are copy-paste errors.
achow101 referenced this in commit 529a0458d8 on Feb 17, 2025

Contributors

Labels

Proposed BIP modification

Linked (view graph)

#1769 373: Correct test data mismatches #2140 Bump rand from 0.9.2 to 0.9.3 in /bip-0360/ref-impl/rust