BIP158: minor error message fixup in gentestvectors.go #1777

pull vipocenka wants to merge 1 commits into bitcoin:master from vipocenka:fix/fix changing 1 files +2 −2
  1. vipocenka commented at 3:30 pm on February 28, 2025: contributor

    Fix up error message:

    • "Couldn't get block hash""Couldn't get block data" for better clarity

    Also minor grammar edit in code comment:

    • "checks for filter size of DefaultP""checks the filter size of DefaultP"
  2. fix gentestvectors.go 6cbe26685a
  3. jonatack commented at 3:50 pm on February 28, 2025: member

    Thank you for your contribution, but I don’t think this patch is an improvement.

    Edit: after re-reading, perhaps it is better.

  4. jonatack renamed this:
    Fix minor error and improve error message in `gentestvectors.go`
    BIP158: minor error message fixup in `gentestvectors.go`
    on Mar 21, 2025
  5. jonatack commented at 2:56 pm on March 21, 2025: member

    ACK 6cbe26685a646eedbd5b05f6a08e418fdd2cdfd5

    The error message is indeed more correct with this change. These are inconsequential editorial improvements not worth bothering the BIP authors about.

  6. jonatack merged this on Mar 21, 2025
  7. jonatack closed this on Mar 21, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-03-29 07:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me