bip-0348: add SUCCESS upgrade VERIFY variant #1780
pull reardencode wants to merge 1 commits into bitcoin:master from reardencode:csfs changing 1 files +20 −14-
reardencode commented at 0:28 am on March 5, 2025: contributorAfter discussion with @jamesob and others, having a VERIFY variant seems the least surprising thing.
-
bip-0348: add SUCCESS upgrade VERIFY variant
After discussion with @jamesob and others, having a VERIFY variant seems the least surprising thing.
-
in bip-0348.md:53 in 6b308d6176
48@@ -46,11 +49,14 @@ successful. 49 * If the signature is not the empty vector: 50 * The opcode is counted towards the sigops budget as described in [BIP 342]. 51 * A 1-byte value 0x01 is pushed onto the stack. 52+* If the opcode being executed is `OP_CHECKSIGFROMSTACKVERIFY`: 53+ * If the signature is the empty vector: script execution immediately terminates with failure
jonatack commented at 5:25 pm on March 7, 2025:0 * If the signature is the empty vector: script execution immediately terminates with failure.
jonatack commented at 5:28 pm on March 7, 2025: memberLGTM modulo nit. Pinging @JeremyRubin for feedback. CI will be green if this is rebased to current master containing #1784.bitcoin deleted a comment on Mar 7, 2025reardencode commented at 5:41 pm on March 8, 2025: contributorAfter discussing with several folks working on CTV+CSFS, this change turns out not to be warranted at this time. Thanks for the review @jonatackreardencode closed this on Mar 8, 2025
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-03-29 07:10 UTC
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-03-29 07:10 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me