bip-0348: add SUCCESS upgrade VERIFY variant #1780

pull reardencode wants to merge 1 commits into bitcoin:master from reardencode:csfs changing 1 files +20 −14

reardencode commented at 12:28 AM on March 5, 2025: contributor

After discussion with @jamesob and others, having a VERIFY variant seems the least surprising thing.

bip-0348: add SUCCESS upgrade VERIFY variant

After discussion with @jamesob and others, having a VERIFY variant seems
the least surprising thing.

6b308d6176

in bip-0348.md:53 in 6b308d6176

  48 | @@ -46,11 +49,14 @@ successful.
  49 |      * If the signature is not the empty vector:
  50 |          * The opcode is counted towards the sigops budget as described in [BIP 342].
  51 |          * A 1-byte value 0x01 is pushed onto the stack.
  52 | +* If the opcode being executed is `OP_CHECKSIGFROMSTACKVERIFY`:
  53 | +    * If the signature is the empty vector: script execution immediately terminates with failure

jonatack commented at 5:25 PM on March 7, 2025:

    * If the signature is the empty vector: script execution immediately terminates with failure.

jonatack commented at 5:28 PM on March 7, 2025: member

LGTM modulo nit. Pinging @JeremyRubin for feedback. CI will be green if this is rebased to current master containing #1784.
bitcoin deleted a comment on Mar 7, 2025
reardencode commented at 5:41 PM on March 8, 2025: contributor

After discussing with several folks working on CTV+CSFS, this change turns out not to be warranted at this time. Thanks for the review @jonatack
reardencode closed this on Mar 8, 2025

Contributors

reardencode

jonatack

Linked (view graph)

#1784 BIP119: appease typos linter