BIPs 67 and 301: fix links #1791

pull wgyt wants to merge 1 commits into bitcoin:master from wgyt:wgyt-bips-patch changing 2 files +2 −2

wgyt commented at 3:11 am on March 16, 2025: contributor

The original master file has been changed, and the line numbers referenced by the original URL are no longer accurate. Therefore, a fixed permanent link is used to replace it. The purpose of adopting a permanent link is to prevent the line numbers originally pointed to by the URL from becoming inaccurate again when further changes are made to the master branch.
bitcoin deleted a comment on Mar 16, 2025
murchandamus commented at 1:09 am on March 18, 2025: contributor

It would help if this pull request came with a bit of context on how you determined the suggested URLs to be the correct replacement of the originals.
wgyt commented at 2:18 am on March 18, 2025: contributor

It would help if this pull request came with a bit of context on how you determined the suggested URLs to be the correct replacement of the originals.

Thanks for your review. I have provided the description.
jonatack renamed this:
~~fix links~~
BIPs 67 and 301: fix links
on Mar 21, 2025
in bip-0067.mediawiki:129 in e9218d64e0 outdated
125@@ -126,7 +126,7 @@ The authors wish to thank BtcDrak and Luke-Jr for their involvement & contributi 126 * [[https://github.com/bitpay/bitcore/blob/50a868cb8cdf2be04bb1c5bf4bcc064cc06f5888/lib/script/script.js#L541|Bitcore]] 127 * [[https://github.com/haskoin/haskoin-core/blob/b41b1deb0989334a7ead6fc993fb8b02f0c00810/haskoin-core/Network/Haskoin/Script/Parser.hs#L112-L122|Haskoin]] - Bitcoin implementation in Haskell 128 * [[https://github.com/etotheipi/BitcoinArmory/blob/268db0f3fa20c989057bd43343a43b2edbe89aeb/armoryengine/ArmoryUtils.py#L1441|Armory]] 129-* [[https://github.com/bitcoinj/bitcoinj/blob/master/core/src/main/java/org/bitcoinj/script/ScriptBuilder.java#L331|BitcoinJ]] 130+* [[https://github.com/bitcoinj/bitcoinj/blob/f7ea0b92a619800c143b0142dc70306da33119a9/core/src/main/java/org/bitcoinj/script/ScriptBuilder.java#L296|BitcoinJ]]
jonatack commented at 2:39 pm on March 21, 2025:

Should this URL not be the following, instead?

https://github.com/bitcoinj/bitcoinj/blob/f7ea0b92a619800c143b0142dc70306da33119a9/core/src/main/java/org/bitcoinj/script/ScriptBuilder.java#L331

wgyt commented at 3:00 pm on March 21, 2025:

Sorry for this wrong fix.

Would https://github.com/bitcoinj/bitcoinj/blob/f7ea0b92a619800c143b0142dc70306da33119a9/core/src/main/java/org/bitcoinj/script/ScriptBuilder.java#L335 be more appropriate here? L335 points to the function rather than the comment quote.

jonatack commented at 3:04 pm on March 21, 2025:

The link title was last updated by a BIP author, Thomas Kerin, in 1c000480 without changing the URL. Would retain the original intent of pointing to the start of the Doxygen above the function.

wgyt commented at 1:17 am on March 22, 2025:

Updated to use https://github.com/bitcoinj/bitcoinj/blob/f7ea0b92a619800c143b0142dc70306da33119a9/core/src/main/java/org/bitcoinj/script/ScriptBuilder.java#L331 now.

Thanks for your review ^_^

in bip-0301.mediawiki:101 in e9218d64e0 outdated

 97@@ -98,7 +98,7 @@ To "Accept" a BMM proposal (endorsing Simon's side:block, and allowing Mary to a
 98     32-bytes - h* (obtained from Simon)
 99 </pre>
100 
101-[https://github.com/LayerTwo-Labs/bip300301_messages/blob/master/src/lib.rs#L252-L264 Code details here].
102+[https://github.com/LayerTwo-Labs/bip300301_messages/blob/dd26518ff9505ea9088436797171799f359d0076/src/lib.rs#L256-L268 Code details here].

jonatack commented at 2:41 pm on March 21, 2025:

This link update appears correct.

jonatack added the label Proposed BIP modification on Mar 21, 2025
fix links 0e3a56c681
wgyt force-pushed on Mar 22, 2025
murchandamus commented at 1:26 am on March 22, 2025: contributor

ACK, LGTM
murchandamus merged this on Mar 22, 2025
murchandamus closed this on Mar 22, 2025
bitcoin deleted a comment on Mar 22, 2025

Contributors
wgyt murchandamus jonatack

Labels
Proposed BIP modification