BIP380: make specs consistent about hardened indicators #1803

pull quapka wants to merge 1 commits into bitcoin:master from quapka:hardened-indicator changing 1 files +2 −1
  1. quapka commented at 8:51 pm on March 27, 2025: none

    Me and my students noticed a discrepancy in the test vectors and specification regarding the allowed characters denoting hardened nodes. The BIP380 specs allows all three h, ' and H, in particular the specs read:

    In the above specification, the hardened indicator h may be replaced with alternative hardened indicators of H or '.

    However, the following is then an invalid test vectors:

    [deadbeef/0H/0H/0H]0260b2003c386519fc9eadf2b5cf124dd8eea4c4e68d5e154050a9346ea98ce600

    Thus, I’ve added new test vectors allowing H and removed the inconsistent one.

    However, I am far from claiming that this is the correct way how to handle this. I’ve checked that people are using the H, but I got no (meaningful or relevant) hits when searching for the exact test vector. I didn’t see the option to create issues, thus I’ve continued by proposing the, what seems to be, reasonable changes.

  2. Make specs consistent about hardened indicators 3d7ff96d7b
  3. jonatack added the label Proposed BIP modification on Mar 28, 2025
  4. jonatack added the label Pending acceptance on Mar 28, 2025
  5. jonatack renamed this:
    Make specs consistent about hardened indicators
    BIP380: make specs consistent about hardened indicators
    on Mar 28, 2025
  6. murchandamus commented at 10:03 pm on March 28, 2025: contributor
    cc: @achow101

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-03-31 19:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me