BIP328: minor docstring fixups #1808

1. 
   futreall commented at 1:50 pm on April 1, 2025: contributor

   2 doc-only fixups.
2. in bip-0328/_base58.py:56 in 351c3d5e5b outdated

   52@@ -53,7 +53,7 @@ def decode(s: str) -> bytes:
   53     """
   54     Decode a base58-encoding string, returning bytes
   55 
   56-    :param s: Base48 string to decode
   57+    :param s: Base58 string to decode
   

   ---

   ---

   

   jonatack commented at 3:16 pm on April 1, 2025:

   Looks like the following should be fixed as well:

   0@@ -118,7 +118,7 @@ def get_xpub_fingerprint_hex(xpub: str) -> str:
   1     """
   2     Get the parent fingerprint as a hex string from an extended public key
   3 
   4-    :param s: The extended pubkey
   5+    :param xpub: The extended pubkey
   6     :return: The parent fingerprint as a hex string
   

3. 
   jonatack commented at 3:17 pm on April 1, 2025: member

   ACK, see comment below for a similar one (please verify if you can find any others in the same BIP).
4. jonatack renamed this:
   fix error `Base48` to `Base58` _base58.py
   BIP328: minor docstring fixups
   on Apr 1, 2025
5. futreall force-pushed on Apr 1, 2025
6. 
   futreall commented at 3:29 pm on April 1, 2025: contributor

   Done , there is no more such error in the files thanks
7. in bip-0328/_base58.py:110 in 81f0e56091 outdated

   106@@ -107,7 +107,7 @@ def get_xpub_fingerprint(s: str) -> bytes:
   107     """
   108     Get the parent fingerprint from an extended public key
   109 
   110-    :param s: The extended pubkey
   111+    :param xpub: The extended pubkey
   

   ---

   ---

   

   jonatack commented at 4:03 pm on April 1, 2025:

   It looks like this line should either remain as-is, or be updated to the name “xpub” in the code of this function.

   ---

   

   jonatack commented at 6:05 pm on April 1, 2025:

   In case I was unclear, the above comment was for this line only, not for #1808 (review).
8. 
   jonatack commented at 4:04 pm on April 1, 2025: member

   One comment on the latest push.
9. futreall force-pushed on Apr 1, 2025
10. futreall force-pushed on Apr 1, 2025
11. 
    futreall commented at 5:48 pm on April 1, 2025: contributor

    @jonatack I’ll keep it as is
12. in bip-0328/_base58.py:56 in 587eef3ca2 outdated

    52@@ -53,7 +53,7 @@ def decode(s: str) -> bytes:
    53     """
    54     Decode a base58-encoding string, returning bytes
    55 
    56-    :param s: Base48 string to decode
    57+    :param s:Base58 string to decode
    

    ---

    ---

    

    jonatack commented at 6:04 pm on April 1, 2025:

    0    :param s: Base58 string to decode
    

13. 
    jonatack commented at 6:04 pm on April 1, 2025: member

    Can you still address #1808 (review) for that one case?
14. fix error Base48 to Base58

    chore: fix error Base48 to Base58
    
    fix error Base48 to Base58

    5772c6b40d
15. futreall force-pushed on Apr 1, 2025
16. 
    futreall commented at 6:20 pm on April 1, 2025: contributor

    Sorry, I wasn’t paying attention , now everything definitely worked out
17. 
    jonatack commented at 7:13 pm on April 1, 2025: member

    ACK 5772c6b40d102164e0e2387536ea5214e714a45d, thanks for updating.
18. jonatack merged this on Apr 1, 2025
19. jonatack closed this on Apr 1, 2025

    ---

Contributors
futreall jonatack