BIP75: fix typo #1823

pull leopardracer wants to merge 10 commits into bitcoin:master from leopardracer:master changing 1 files +1 −1
  1. leopardracer commented at 11:52 am on April 13, 2025: contributor
    This PR fixes a typo.
  2. Update bip-0042.mediawiki 468de16c8f
  3. Update bip-0044.mediawiki b71e3b2daa
  4. Update bip-0047.mediawiki 1528dfd3f4
  5. Update bip-0042.mediawiki b8b050a981
  6. vostrnad commented at 12:22 pm on April 13, 2025: contributor
    “Mibillenium” is an intentional pun, and “cryptocoin” is a completely valid synonym for “cryptocurrency”.
  7. Update bip-0042.mediawiki 8cf86af768
  8. Update bip-0042.mediawiki 1689a38f53
  9. Update bip-0044.mediawiki d1e48c476d
  10. leopardracer commented at 12:30 pm on April 13, 2025: contributor

    “Mibillenium” is an intentional pun, and “cryptocoin” is a completely valid synonym for “cryptocurrency”.

    fixed

  11. Update bip-0047.mediawiki 487e66da6a
  12. in bip-0047.mediawiki:341 in d1e48c476d outdated
    337@@ -338,7 +338,7 @@ In order to use Bitmessage notification, the recipient must have a Bitmessage cl
    338 
    339 ==Version 2==
    340 
    341-Version 2 payment codes behave identifically to version 1 payment codes, except as modified below.
    342+Version 2 payment codes behave identically to version 1 payment codes, except as modified below.
    


    jonatack commented at 12:40 pm on April 13, 2025:
    “identifically” is not incorrect
  13. leopardracer requested review from jonatack on Apr 13, 2025
  14. in bip-0047.mediawiki:88 in d1e48c476d outdated
    84@@ -85,7 +85,7 @@ This derivation level is equivalent to the Account level in BIP-44. Wallets SHOU
    85 
    86 For example, the payment code created represented by (m / 47' / 0' / 0') is part of the account represented by (m / 44' / 0' / 0').
    87 
    88-The second account in a wallet consists of the new account/payment code pair created by using an index of 1 in as the account/identity level of both paths.
    89+The second account in a wallet consists of the new account/payment code pair created by using an index of 1 used as the account/identity level of both paths.
    


    jonatack commented at 12:50 pm on April 13, 2025:
    I’m not sure if this change reflects the author’s intent. It looks to me like the author’s intent was either “in” or “as” without the other, but would need to look further or ask the author.
  15. jonatack renamed this:
    Fix typos: "mibillenium" to "millenium" and "cryptocoin" to "cryptocurrency"
    BIP47: fix typo
    on Apr 13, 2025
  16. Update bip-0075.mediawiki f05e649d61
  17. leopardracer renamed this:
    BIP47: fix typo
    BIP75: fix typo
    on Apr 13, 2025
  18. Update bip-0047.mediawiki 329a037b9e
  19. leopardracer requested review from jonatack on Apr 13, 2025
  20. leopardracer commented at 12:18 pm on April 14, 2025: contributor
  21. murchandamus commented at 3:17 pm on April 14, 2025: contributor
    Thanks for fixing the typo, but ten commits and several reviewer interactions are a lot of effort for such a trivial improvement. Preferably only open a pull request if there is a more substantial improvement to be made.
  22. murchandamus merged this on Apr 14, 2025
  23. murchandamus closed this on Apr 14, 2025

  24. leopardracer commented at 3:18 pm on April 14, 2025: contributor

    Thanks for fixing the typo, but ten commits and several reviewer interactions are a lot of effort for such a trivial improvement. Preferably only open a pull request if there is a more substantial improvement to be made.

    Sorry, I’ll take that into account next time


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-04-19 01:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me