BIP-0085: minor docstring fixups #1827

pull futreall wants to merge 1 commits into bitcoin:master from futreall:master changing 1 files +1 −1
  1. futreall commented at 7:02 am on April 16, 2025: contributor
    hey team ! please correct the error, thank you
  2. minor docstring fixups bip-0085.mediawiki 74c34a81c4
  3. in bip-0085.mediawiki:60 in 74c34a81c4
    56@@ -57,7 +57,7 @@ We assume a single BIP32 master root key. This specification is not concerned wi
    57 
    58 For each application that requires its own wallet, a unique private key is derived from the BIP32 master root key using a fully hardened derivation path. The resulting private key (k) is then processed with HMAC-SHA512, where the key is "bip-entropy-from-k", and the message payload is the private key k: <code>HMAC-SHA512(key="bip-entropy-from-k", msg=k)</code>
    59 <ref name="hmac-sha512">
    60-The reason for running the derived key through HMAC-SHA512 and truncating the result as necessary is to prevent leakage of the parent tree should the derived key (''k'') be compromised. While the specification requires the use of hardended key derivation which would prevent this, we cannot enforce hardened derivation, so this method ensures the derived entropy is hardened. Also, from a semantic point of view, since the purpose is to derive entropy and not a private key, we are required to transform the child key. This is done out of an abundance of caution, in order to ward off unwanted side effects should ''k'' be used for a dual purpose, including as a nonce ''hash(k)'', where undesirable and unforeseen interactions could occur.
    61+The reason for running the derived key through HMAC-SHA512 and truncating the result as necessary is to prevent leakage of the parent tree should the derived key (''k'') be compromised. While the specification requires the use of hardened key derivation which would prevent this, we cannot enforce hardened derivation, so this method ensures the derived entropy is hardened. Also, from a semantic point of view, since the purpose is to derive entropy and not a private key, we are required to transform the child key. This is done out of an abundance of caution, in order to ward off unwanted side effects should ''k'' be used for a dual purpose, including as a nonce ''hash(k)'', where undesirable and unforeseen interactions could occur.
    


    jonatack commented at 2:18 pm on April 16, 2025:
    This typo is also fixed in #1828, so not labeling this PR as Typo-to-be-collected.
  4. jonatack commented at 2:20 pm on April 16, 2025: member
    Thank you for your proposal. We no longer directly merge PRs of this type, as we have been seeing a high frequency of them, they generally require more time than they are worth, and they create unneeded notifications for subscribers to this repository. (There may be exceptions for higher-value proposals by longstanding reviewers of this repository.) We’ll instead be batching these kinds of changes into an occasional cleanup commit by the editors that might mention the authors of some of the more valuable typos found.
  5. jonatack closed this on Apr 16, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-04-19 01:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me