BIP-345: withdraw #1848

pull jamesob wants to merge 1 commits into bitcoin:master from jamesob:jamesob-25-05-withdraw-vault changing 2 files +4 −3
  1. jamesob commented at 3:40 pm on May 6, 2025: contributor
    This proposal has basically been replaced by #1793. See https://delvingbitcoin.org/t/withdrawing-op-vault-bip-345/1670 for rationale.
  2. in bip-0345.mediawiki:8 in c09fcd6604 outdated
    4@@ -5,7 +5,7 @@
    5   Author: James O'Beirne <vaults@au92.org>
    6           Greg Sanders <gsanders87@gmail.com>
    7   Comments-URI: https://github.com/bitcoin/bips/wiki/Comments:BIP-0345
    8-  Status: Draft
    9+  Status: Withdrawn
    


    jonatack commented at 8:48 pm on May 6, 2025:
    The README would need updating as well.

    jonatack commented at 8:53 pm on May 6, 2025:

    Probably a diff like this

     0diff --git a/README.mediawiki b/README.mediawiki
     1index fe3be265..2ea96ed3 100644
     2--- a/README.mediawiki
     3+++ b/README.mediawiki
     4@@ -1127,13 +1127,13 @@ Standard
     5 | Final
     6-|-
     7+|- style="background-color: #ffcfcf"
     8 | [[bip-0345.mediawiki|345]]
     9 | Consensus (soft fork)
    10 | OP_VAULT
    11 | James O'Beirne, Greg Sanders
    12 | Standard
    13-| Draft
    14+| Withdrawn
    15 |-
    16 | [[bip-0347.mediawiki|347]]
    17 | Consensus (soft fork)
    

    murchandamus commented at 10:34 pm on May 7, 2025:
    Based on your comment, you may also want to add Superseded-By: [bip-number-of-OP_CCV-coming-soon™] below the Post-History header.

    murchandamus commented at 5:33 pm on May 8, 2025:
    I.e., Superseded-By: 443.
  3. jonatack added the label Proposed BIP modification on May 6, 2025
  4. jamesob force-pushed on May 8, 2025
  5. in README.mediawiki:1136 in 65c0f7b497 outdated
    1132@@ -1133,7 +1133,7 @@ Those proposing changes should consider that ultimately consent may rest with th
    1133 | OP_VAULT
    1134 | James O'Beirne, Greg Sanders
    1135 | Standard
    1136-| Draft
    1137+| Withdrawn
    


    murchandamus commented at 6:03 pm on May 8, 2025:

    Line 1130 should be

    |- style=“background-color: #ffcfcf”

    to match the status change.

  6. in bip-0345.mediawiki:9 in 65c0f7b497 outdated
     4@@ -5,7 +5,8 @@
     5   Author: James O'Beirne <vaults@au92.org>
     6           Greg Sanders <gsanders87@gmail.com>
     7   Comments-URI: https://github.com/bitcoin/bips/wiki/Comments:BIP-0345
     8-  Status: Draft
     9+  Status: Withdrawn
    10+  Superseded-By: 443
    


    murchandamus commented at 6:03 pm on May 8, 2025:
    Please move the Superseded-By header below the Post-History header. The headers are required to be in a specific order.
  7. murchandamus commented at 6:04 pm on May 8, 2025: contributor
    The CI is failing because of the color of the table row in the README.mediawiki
  8. BIP-345: withdraw b771054d4d
  9. murchandamus force-pushed on May 8, 2025
  10. murchandamus commented at 6:36 pm on May 8, 2025: contributor
    Edited with permission of @jamesob to fix CI issue. Checked with @instagibbs out-of-band who supports the change.
  11. murchandamus merged this on May 8, 2025
  12. murchandamus closed this on May 8, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-30 04:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me