BIP-372: Fix references and links formatting and minor typos #1849

pull mutestt wants to merge 1 commits into bitcoin:master from mutestt:fix/fix changing 1 files +16 −20
  1. mutestt commented at 4:35 pm on May 13, 2025: contributor

    Fixed incorrect preposition in key tweaking explanation:

    • multiplied onmultiplied by

    • Clarified BIP-340 key serialization:

      • appending '02'appending '0x02'
    • Removed unnecessary trailing comma in the list of output types

    • Removed erroneous semicolon after URL

  2. in bip-0372.mediawiki:185 in 363e02124f outdated
    181@@ -182,7 +182,7 @@ TBD
    182     <https://petertodd.org/2016/opentimestamps-announcement>
    183 [4] Adam Back, Matt Corallo, Luke Dashjr, et al. Enabling Blockchain
    184     Innovations with Pegged Sidechains (commit5620e43). Appendix A.
    185-    <https://blockstream.com/sidechains.pdf>;.
    186+    <https://blockstream.com/sidechains.pdf>.
    


    jonatack commented at 9:55 pm on May 13, 2025:
    While here, perhaps worth updating the non-functional links to mediawiki format so that they work correctly.
  3. jonatack commented at 9:59 pm on May 13, 2025: member

    Thank you for your proposal. We usually no longer merge “fix typos and grammar” PRs directly, as we were seeing a high frequency of them, they can require more time than they are worth, and they create unneeded notifications for subscribers to this repository. We instead batch these kinds of changes into an occasional cleanup by the editors and credit you as an author when we do that.

    That said, I think this pull could add value beyond “typo fixes” if you update it to also convert the non-functional links to mediawiki format. Thoughts?

  4. mutestt commented at 11:26 am on May 14, 2025: contributor
    @jonatack I’ve updated the PR as suggested: all non-functional and raw URLs in the references section have now been converted to proper MediaWiki format. Please let me know if anything else needs to be adjusted.
  5. jonatack commented at 2:07 pm on May 15, 2025: member
    Looks good, modulo why did you add italics, and then remove them again in the last commit ce19ffa399cff9e8b3ab07414cedd9f265b83d4e? (No strong opinion but does seem more readable with italics.)
  6. jonatack renamed this:
    BIP-372: Fix typos and grammatical inconsistencies
    BIP-372: Fix references and links formatting and minor typos
    on May 15, 2025
  7. mutestt commented at 2:51 pm on May 15, 2025: contributor
    @jonatack I’ve restored the italics around the reference titles as suggested. Let me know if there’s anything else you’d like adjusted.
  8. jonatack commented at 3:43 pm on May 15, 2025: member
    ACK bd599fbb17b218c864733c4bb63e1265bc34adea
  9. BIP372: Fix footnote formatting, minor issues 50a692d82e
  10. murchandamus force-pushed on May 16, 2025
  11. murchandamus commented at 4:51 pm on May 16, 2025: contributor

    Squashed the six commits.

    LGTM

  12. murchandamus merged this on May 16, 2025
  13. murchandamus closed this on May 16, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-30 04:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me