BIP48: Partially revert recent changes, move to final #1850
pull murchandamus wants to merge 4 commits into bitcoin:master from murchandamus:Revert-bip48-update changing 2 files +6 −26-
murchandamus commented at 8:11 pm on May 13, 2025: contributorAs discussed on #1835#pullrequestreview-2837827946, the addition to P2TR was incompletely specified, and BIP48 should no longer be changed. Therefore, I propose to revert the changes, and to move BIP48 to final instead.
-
Revert "BIP48: Add p2tr script type derivation"
This reverts commit e7cf2e9149f9cbec36c07d7f02eacc16eaa306f5.
-
Revert P2TR example from "BIP48: Add P2SH-P2WSH and P2TR mainnet examples"
This partially reverts commit 9c22bcef63b5daa2d3407149701a03b6777b604a.
-
BIP48: Move to final fc946e1989
-
murchandamus added the label Proposed BIP modification on May 13, 2025
-
murchandamus commented at 8:13 pm on May 13, 2025: contributorPinging BIP author @Fonta1n3, and PR author @ben-kaufman to request review.
-
murchandamus added the label Pending acceptance on May 13, 2025
-
jonatack commented at 9:48 pm on May 13, 2025: memberLGTM, appears to revert the changes as expected and correctly updates to final status.
-
in bip-0048.mediawiki:116 in fc946e1989 outdated
117-The following path represents Taproot (p2tr) mainnet, account 0: 118-<code>3'</code>: Taproot (p2tr) <code>m/48'/0'/0'/3'</code></br> 119- 120 The recommended default for wallets is pay to witness script hash <code>m/48'/0'/0'/2'</code>. 121 122 To add new script types submit a PR to this specification and include it in the list above:
ben-kaufman commented at 0:09 am on May 14, 2025:Would it make sense to also remove this part on adding new scripts?
murchandamus commented at 10:13 pm on May 14, 2025:Ah, good catch! Thanks.BIP48: Remove invitation to add more script types adafc92b98jonatack commented at 2:00 pm on May 15, 2025: memberACK adafc92b9857337c10ccdd0c4eaac2900b6a3048ben-kaufman commented at 10:43 pm on May 15, 2025: contributorFonta1n3 commented at 0:38 am on May 22, 2025: contributorjonatack removed the label Pending acceptance on May 22, 2025jonatack merged this on May 22, 2025jonatack closed this on May 22, 2025
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-30 04:10 UTC
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-30 04:10 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me