bip-0331: correct size of version field in sendpackages #1853

pull kcalvinalvin wants to merge 1 commits into bitcoin:master from kcalvinalvin:patch-1 changing 1 files +1 −1
  1. kcalvinalvin commented at 3:30 am on May 19, 2025: contributor
    Since the version is denoted as uint64, the size should be 8 bytes.
  2. bip-0331: correct size of version field in sendpackages
    Since the version is denoted as uint64, the size should be 8 bytes.
    5d82f82693
  3. jonatack added the label Proposed BIP modification on May 19, 2025
  4. jonatack added the label Bug fix on May 19, 2025
  5. jonatack added the label Pending acceptance on May 19, 2025
  6. jonatack assigned jonatack on May 19, 2025
  7. jonatack unassigned jonatack on May 19, 2025
  8. jonatack unassigned jonatack on May 19, 2025
  9. jonatack commented at 2:55 pm on May 19, 2025: member
    cc BIP author @glozow for approval or feedback
  10. glozow commented at 3:26 pm on May 19, 2025: member
    LGTM, thanks
  11. jonatack removed the label Pending acceptance on May 19, 2025
  12. jonatack commented at 3:32 pm on May 19, 2025: member
    ACK 5d82f82693942c08e1d732c5ec9b58e79b3c2339 64 bits (uint64) should take 8 bytes in general
  13. jonatack merged this on May 19, 2025
  14. jonatack closed this on May 19, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-30 04:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me