bip-0331: correct size of version field in sendpackages #1853

pull kcalvinalvin wants to merge 1 commits into bitcoin:master from kcalvinalvin:patch-1 changing 1 files +1 −1

kcalvinalvin commented at 3:30 AM on May 19, 2025: contributor

Since the version is denoted as uint64, the size should be 8 bytes.

bip-0331: correct size of version field in sendpackages

Since the version is denoted as uint64, the size should be 8 bytes.

5d82f82693

jonatack added the label Proposed BIP modification on May 19, 2025
jonatack added the label Bug fix on May 19, 2025
jonatack added the label Pending acceptance on May 19, 2025
jonatack assigned jonatack on May 19, 2025
jonatack unassigned jonatack on May 19, 2025
jonatack unassigned jonatack on May 19, 2025
jonatack commented at 2:55 PM on May 19, 2025: member

cc BIP author @glozow for approval or feedback
glozow commented at 3:26 PM on May 19, 2025: member

LGTM, thanks
jonatack removed the label Pending acceptance on May 19, 2025
jonatack commented at 3:32 PM on May 19, 2025: member

ACK 5d82f82693942c08e1d732c5ec9b58e79b3c2339 64 bits (uint64) should take 8 bytes in general
jonatack merged this on May 19, 2025
jonatack closed this on May 19, 2025

Contributors

Labels