BIP21: correct invalid address in examples #1861

pull ethicnology wants to merge 1 commits into bitcoin:master from ethicnology:master changing 1 files +6 −6
  1. ethicnology commented at 2:13 pm on May 29, 2025: none

    The address from BIP21 examples seems invalid.

    I’m failing to parse it using BDK flutter with the error AddressException( Base58 encoding error: base58ck checksum 0x29619c8a does not match expected 0x11619c8a )

    Online tools also fails to validate it.

    This commit replace the address 175tWpb8K1S7NmH4Zx6rewF9WQrcZv245W by 1BvBMSEYstWetqTFn5Au4m4GFg7xJaNVN2 from the Bitcoin wiki to save debugging time for devs that may face the same issue in the future.

  2. fix: bip21 example invalid address f831eededf
  3. jonatack added the label Pending acceptance on May 29, 2025
  4. jonatack added the label Bug fix on May 29, 2025
  5. jonatack commented at 3:57 pm on May 29, 2025: member
    cc BIP author @TheBlueMatt for feedback
  6. ethicnology renamed this:
    fix: Invalid address in BIP21 example
    BIP21: correct invalid address in BIP21 example
    on May 29, 2025
  7. ethicnology renamed this:
    BIP21: correct invalid address in BIP21 example
    BIP21: correct invalid address in examples
    on May 29, 2025
  8. murchandamus commented at 0:45 am on May 31, 2025: contributor
    This may have been on purpose, given that it is examples and not test vectors, because in the past people have sent money to addresses published in BIPs or Bitcoin books which were no longer held by anyone or for which it was then unclear where the funds should be sent.

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-31 07:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me