383: Fix output scripts and reword minimal encoding explanation #1865

pull achow101 wants to merge 1 commits into bitcoin:master from achow101:383-fix-scripts changing 1 files +5 −6
  1. achow101 commented at 10:44 pm on June 3, 2025: member

    Fixes the output script template to correctly include the n value.

    Also changed how the minimal encoding is described to just describe it rather than an exhaustive list.

    Alternate to #1860

  2. jonatack added the label Proposed BIP modification on Jun 4, 2025
  3. jonatack added the label Bug fix on Jun 4, 2025
  4. murchandamus commented at 6:26 pm on June 4, 2025: contributor
    LGTM
  5. jonatack commented at 8:28 pm on June 4, 2025: member
    ACK, perhaps give @dr-orlovsky co-authored-by credit for having found the issue.
  6. rkrux commented at 12:42 pm on June 5, 2025: none

    ACK 180a699266390594b17eb716dda7f852d42bbea1

    n was missing in the output script before the opcode prior to this diff.

  7. achow101 force-pushed on Jun 5, 2025
  8. achow101 commented at 8:22 pm on June 5, 2025: member

    ACK, perhaps give @dr-orlovsky co-authored-by credit for having found the issue.

    Done

  9. 383: Fix output scripts and reword minimal encoding explanation
    Co-Authored-By: Dr. Maxim Orlovsky <orlovsky@lnp-bp.org>
    ee7accaf5f
  10. jonatack merged this on Jun 5, 2025
  11. jonatack closed this on Jun 5, 2025

  12. jonatack commented at 8:33 pm on June 5, 2025: member
    Closes #1860 (thanks!)

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-18 18:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me