bip373: add hyperlinks to other BIPs #1886

pull GuroChil wants to merge 5 commits into bitcoin:master from GuroChil:master changing 1 files +10 −9
  1. GuroChil commented at 4:38 pm on July 1, 2025: contributor
    add hyperlinks to BIPs 327
  2. Update bip-0373.mediawiki ac9c666c14
  3. in bip-0373.mediawiki:28 in ac9c666c14 outdated 
    24@@ -25,7 +25,7 @@ This BIP is licensed under the Creative Commons CC0 1.0 Universal license.
25 
26 ===Motivation===
27 
28-BIP 327 specifies a way to create BIP 340 compatible public keys and signatures using the MuSig2
29+[[bip-0327.mediawiki|BIP-327]] specifies a way to create BIP 340 compatible public keys and signatures using the MuSig2
    jonatack commented at 8:51 pm on July 1, 2025:

    Hi @GuroChil, a few questions:

    • why omit the first use of “BIP 327” on lines 18-19 (and would that first one suffice)
    • why only for BIP 327
    • why change the format from “BIP 327” to “BIP-327”, when the non-hyphenated version was chosen by the author of this BIP
    GuroChil commented at 5:24 am on July 2, 2025:
    Thanks for the detailed review! I’ve addressed all points: Added the first BIP 327 reference on lines 18-19 Applied consistent formatting across other BIPs as well Reverted back to non-hyphenated format as per original author’s style
  4. Update bip-0373.mediawiki dfc9144848
  5. Update bip-0373.mediawiki fd72bd8644
  6. in bip-0373.mediawiki:20 in fd72bd8644 outdated 
    14@@ -15,19 +15,19 @@
15 
16 ===Abstract===
17 
18-This document proposes additional fields for BIP 174 PSBTv0 and BIP 370 PSBTv2 that allow for BIP
19-327 MuSig2 Multi-Signature data to be included in a PSBT of any version. These will be fields for
20-the participants' keys, the public nonces, and the partial signatures produced with MuSig2.
21+This document proposes additional fields for [[bip-0174.mediawiki|BIP 174]] PSBTv0 and [[bip-0370.mediawiki|BIP 370]] 
22+PSBTv2 that allow for [[bip-0327.mediawiki|BIP 327]] MuSig2 Multi-Signature data to be included in a PSBT of any version. 
23+These will be fields for the participants' keys, the public nonces, and the partial signatures produced with MuSig2.
    murchandamus commented at 9:15 pm on July 2, 2025:

    Please don’t change where the lines break in the sentence when you are only editing single words. Instead leave the line breaks where they are and allow longer lines to minimize visual clutter in the diff.

    0This document proposes additional fields for [[bip-0174.mediawiki|BIP 174]] PSBTv0 and [[bip-0370.mediawiki|BIP 370]] PSBTv2 that allow for
1[[bip-0327.mediawiki|BIP 327]] MuSig2 Multi-Signature data to be included in a PSBT of any version. These will be fields for
2the participants' keys, the public nonces, and the partial signatures produced with MuSig2.
  7. in bip-0373.mediawiki:165 in fd72bd8644 outdated 
    161@@ -162,7 +162,7 @@ to produce a signature for, if the signer does not find an existing
162 the <tt>NonceGen</tt> algorithm (or one of its variations) to produce a public
163 nonce that is added in a <tt>PSBT_IN_MUSIG2_PUB_NONCE</tt> field. However
164 signers must keep in mind that '''improper nonce usage can compromise private
165-keys.''' Please see BIP 327 for best practices on nonce generation and usage.
166+keys.''' Please see [[bip-0327.mediawiki|BIP-327]] for best practices on nonce generation and usage.
    murchandamus commented at 9:16 pm on July 2, 2025:
    Nit: Please drop the dash for consistency.
    GuroChil commented at 5:25 am on July 3, 2025:
    Thank you for the feedback! I’ve implemented all the suggested changes. Please let me know if you have any other recommendations.
  8. murchandamus changes_requested
  9. murchandamus commented at 9:17 pm on July 2, 2025: contributor
    Please update all the edits to undo the unnecessary sentence shifts due to changing where the lines break.
  10. Update bip-0373.mediawiki 
    I've implemented all the suggested changes
    0369d7102a
  11. in bip-0373.mediawiki:30 in 0369d7102a outdated 
    29-Multi-Signature scheme. The existing PSBT fields are unable to support MuSig2 as it introduces new
30-concepts and additional rounds of communication. Therefore new fields must be defined to allow PSBTs
31-to carry the information necessary to produce a valid signature with MuSig2.
32+[[bip-0327.mediawiki|BIP 327]] specifies a way to create [[bip-0340.mediawiki|BIP 340]] compatible public keys and signatures using the MuSig2 
33+Multi-Signature scheme. The existing PSBT fields are unable to support MuSig2 asit introduces new concepts and additional rounds of communication. 
34+Therefore new fields must be defined to allow PSBTs to carry the information necessary to produce a valid signature with MuSig2.
    murchandamus commented at 5:28 pm on July 3, 2025: 
    0[[bip-0327.mediawiki|BIP 327]] specifies a way to create [[bip-0340.mediawiki|BIP 340]] compatible public keys and signatures using the MuSig2
1Multi-Signature scheme. The existing PSBT fields are unable to support MuSig2 as it introduces new
2concepts and additional rounds of communication. Therefore new fields must be defined to allow PSBTs
3to carry the information necessary to produce a valid signature with MuSig2.
  12. in bip-0373.mediawiki:19 in 0369d7102a outdated 
    14@@ -15,8 +15,8 @@
15 
16 ===Abstract===
17 
18-This document proposes additional fields for BIP 174 PSBTv0 and BIP 370 PSBTv2 that allow for BIP
19-327 MuSig2 Multi-Signature data to be included in a PSBT of any version. These will be fields for
20+This document proposes additional fields for [[bip-0174.mediawiki|BIP 174]] PSBTv0 and [[bip-0370.mediawiki|BIP 370]] PSBTv2 that allow for 
21+[[bip-0327.mediawiki|BIP 327]] MuSig2 Multi-Signature data to be included in a PSBT of any version. These will be fields for
    murchandamus commented at 5:28 pm on July 3, 2025: 
    0[[bip-0327.mediawiki|BIP 327]] MuSig2 Multi-Signature data to be included in a PSBT of any version. These will be fields for
  13. in bip-0373.mediawiki:57 in 0369d7102a outdated 
    56-include their evenness byte as well. Furthermore, PSBT_IN_TAP_BIP32_DERIVATION fields include fingerprints to identify
57-master keys, and these fingerprints require the y-coordinate of the public key, so x-only serialization can't be used.
58+[[bip-0032.mediawiki|BIP 32]] public keys can be derived from a [[bip-0327.mediawiki|BIP 327]] MuSig2 aggregate public key 
59+(see: [[bip-0328.mediawiki|BIP 328]]).But since BIP 32 requires public keys to include their evenness byte, [[bip-0327.mediawiki|BIP 327]]
60+MuSig2 aggregate public keys must include their evenness byte as well. Furthermore, PSBT_IN_TAP_BIP32_DERIVATION fields include 
61+fingerprints to identify master keys, and these fingerprints require the y-coordinate of the public key, so x-only serialization can't be used.
    murchandamus commented at 5:30 pm on July 3, 2025: 
    0(see: [[bip-0328.mediawiki|BIP 328]]).But since BIP 32 requires public keys to include their evenness byte, [[bip-0327.mediawiki|BIP 327]] MuSig2 aggregate public key (see: [[bip-0328.mediawiki|BIP 328]]).
1But since BIP 32 requires public keys to include their evenness byte, BIP 327 MuSig2 aggregate public keys must
2include their evenness byte as well. Furthermore, PSBT_IN_TAP_BIP32_DERIVATION fields include fingerprints to identify
3master keys, and these fingerprints require the y-coordinate of the public key, so x-only serialization can't be used.
  14. in bip-0373.mediawiki:93 in 0369d7102a outdated 
    88@@ -90,8 +89,8 @@ it was derived from, if it was derived from an aggregate key.
89 | rowspan="2"| 0, 2
90 |-
91 | The compressed public key of the participant providing this partial signature, followed by the
92-compressed public key the participant is providing the signature for, followed by the BIP 341 tapleaf hash
93-of the Taproot leaf script that will be signed. If the aggregate key is the Taproot internal key or
94+compressed public key the participant is providing the signature for, followed by the [[bip-0341.mediawiki|BIP 341]]
95+tapleaf hash of the Taproot leaf script that will be signed. If the aggregate key is the Taproot internal key or
    murchandamus commented at 5:30 pm on July 3, 2025: 
    0compressed public key the participant is providing the signature for, followed by the [[bip-0341.mediawiki|BIP 341]] tapleaf hash
1of the Taproot leaf script that will be signed. If the aggregate key is the Taproot internal key or
  15. in bip-0373.mediawiki:184 in 0369d7102a outdated 
    183 already been done.
184 
185-Otherwise, the resulting signature is a BIP 340 compatible signature and finalizers should treat it
186-as such.
187+Otherwise, the resulting signature is a [[bip-0340.mediawiki|BIP 340]] compatible signature and
188+finalizers should treat it as such.
    murchandamus commented at 5:30 pm on July 3, 2025: 
    0Otherwise, the resulting signature is a [[bip-0340.mediawiki|BIP 340]] compatible signature and finalizers should treat it
1as such.
  16. in bip-0373.mediawiki:176 in 0369d7102a outdated 
    171@@ -173,16 +172,16 @@ Signers must remember to apply any relevant tweaks such as a tweak that is the r
172 BIP 32 unhardened derivation with the aggregate public key as the parent key.
173 
174 If all other signers have provided a <tt>PSBT_IN_MUSIG2_PARTIAL_SIG</tt>, then the final signer may
175-perform the <tt>PartialSigAgg</tt> algorithm and produce a BIP 340 compatible signature that can be
176-placed into a <tt>PSBT_IN_TAP_KEY_SIG</tt> or a <tt>PSBT_IN_TAP_SCRIPT_SIG</tt>.
177+perform the <tt>PartialSigAgg</tt> algorithm and produce a [[bip-0340.mediawiki|BIP 340]] compatible 
178+signature that can be placed into a <tt>PSBT_IN_TAP_KEY_SIG</tt> or a <tt>PSBT_IN_TAP_SCRIPT_SIG</tt>.
    murchandamus commented at 5:30 pm on July 3, 2025: 
    0perform the <tt>PartialSigAgg</tt> algorithm and produce a [[bip-0340.mediawiki|BIP 340]] compatible signature that can be
1placed into a <tt>PSBT_IN_TAP_KEY_SIG</tt> or a <tt>PSBT_IN_TAP_SCRIPT_SIG</tt>.
  17. murchandamus changes_requested
  18. murchandamus commented at 5:34 pm on July 3, 2025: contributor
    Maybe I was unclear, but you overlooked a few.
  19. bip373: Undo shifts in linebreaks a1a87c7a13
  20. murchandamus approved
  21. murchandamus commented at 5:45 pm on July 3, 2025: contributor
    Fixed it myself to spend less time on this.
  22. murchandamus renamed this:
    add hyperlinks to BIPs 327
    bip373: add hyperlinks to other BIPs
    on Jul 3, 2025
  23. murchandamus merged this on Jul 3, 2025
  24. murchandamus closed this on Jul 3, 2025


GuroChil jonatack murchandamus

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-06 06:10 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me