BIP32: Use plural “bytes” #1899

pull dplusplus1024 wants to merge 1 commits into bitcoin:master from dplusplus1024:patch-7 changing 1 files +1 −1

dplusplus1024 commented at 1:07 AM on July 20, 2025: contributor

Typo fixup: Align the first field in the serialization table with the rest, which use plural “bytes” (e.g., “4 bytes: child number”) for consistency.

Fix: Use plural “bytes” in serialization table to match field size convention

Aligns the first field in the serialization table with the rest, which use plural “bytes” (e.g., “4 bytes: child number”) for consistency.

651e273ee8

jonatack added the label Typo-to-be-collected on Jul 20, 2025
jonatack renamed this:
~~Fix: Use plural “bytes” in serialization table to match field size co…~~
BIP32: Use plural “bytes”
on Jul 20, 2025
Noxcheborz commented at 9:36 AM on July 20, 2025: none

Danke

in bip-0032.mediawiki:133 in 651e273ee8

 129 | @@ -130,7 +130,7 @@ The first 32 bits of the identifier are called the key fingerprint.
 130 |  ===Serialization format===
 131 |  
 132 |  Extended public and private keys are serialized as follows:
 133 | -* 4 byte: version bytes (mainnet: 0x0488B21E public, 0x0488ADE4 private; testnet: 0x043587CF public, 0x04358394 private)
 134 | +* 4 bytes: version bytes (mainnet: 0x0488B21E public, 0x0488ADE4 private; testnet: 0x043587CF public, 0x04358394 private)

jonatack commented at 11:09 PM on July 23, 2025:

Generally, we collect all the typos at the end of the month into one pull request. At the moment, the only other typo fix this month is #1892 (review).

murchandamus merged this on Jul 28, 2025
murchandamus closed this on Jul 28, 2025
murchandamus commented at 8:53 PM on July 28, 2025: contributor

I decided to merge this, since it seemed like less work after having looked at this PR a few times already.
jonatack commented at 9:27 PM on July 28, 2025: member

#1905 was just opened 😄
murchandamus removed the label Typo-to-be-collected on Jul 28, 2025
murchandamus added the label Typo-to-be-collected on Jul 28, 2025

Contributors

Labels