BIP374: remove debug print from test runner #1920

pull strmfos wants to merge 1 commits into bitcoin:master from strmfos:master changing 1 files +0 −1
  1. strmfos commented at 5:18 pm on August 9, 2025: contributor
    Remove leftover debug print statement that was printing private keys(seckey_a_hex) to console during test execution. Improves test output readability and consistency.
  2. BIP374: remove debug print statement from BIP-374 test runner 1421be407e
  3. jonatack added the label Proposed BIP modification on Aug 9, 2025
  4. jonatack renamed this:
    BIP374: remove debug print statement from BIP-374 test runner
    BIP374: remove debug print from test runner
    on Aug 9, 2025
  5. in bip-0374/run_test_vectors.py:26 in 1421be407e
    22@@ -23,7 +23,6 @@
    23     next(reader)
    24     for row in reader:
    25         (index, point_G_hex, seckey_a_hex, point_B_hex, aux_rand_hex, msg_hex, result_str, comment) = row
    26-        print(seckey_a_hex)
    


    jonatack commented at 5:42 pm on August 9, 2025:
    The test runner output is indeed more clear and consistent after this change.
  6. jonatack commented at 5:44 pm on August 9, 2025: member
    LGTM, but needs approval from a BIP author: @andrewtoth, @RubenSomsen, @theStack WDYT?
  7. jonatack added the label Pending acceptance on Aug 9, 2025
  8. theStack approved
  9. theStack commented at 10:41 pm on August 9, 2025: contributor
    ACK 1421be407e93fe364850cace8126553ef19a2406
  10. jonatack removed the label Pending acceptance on Aug 9, 2025
  11. jonatack commented at 9:40 pm on August 10, 2025: member
    Thanks @theStack 👍
  12. jonatack merged this on Aug 10, 2025
  13. jonatack closed this on Aug 10, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-08-19 23:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me