BIP374: remove debug print from test runner #1920

pull strmfos wants to merge 1 commits into bitcoin:master from strmfos:master changing 1 files +0 −1

strmfos commented at 5:18 PM on August 9, 2025: contributor

Remove leftover debug print statement that was printing private keys(seckey_a_hex) to console during test execution. Improves test output readability and consistency.
BIP374: remove debug print statement from BIP-374 test runner 1421be407e
jonatack added the label Proposed BIP modification on Aug 9, 2025
jonatack renamed this:
~~BIP374: remove debug print statement from BIP-374 test runner~~
BIP374: remove debug print from test runner
on Aug 9, 2025

in bip-0374/run_test_vectors.py:26 in 1421be407e

  22 | @@ -23,7 +23,6 @@
  23 |      next(reader)
  24 |      for row in reader:
  25 |          (index, point_G_hex, seckey_a_hex, point_B_hex, aux_rand_hex, msg_hex, result_str, comment) = row
  26 | -        print(seckey_a_hex)

jonatack commented at 5:42 PM on August 9, 2025:

The test runner output is indeed more clear and consistent after this change.

jonatack commented at 5:44 PM on August 9, 2025: member

LGTM, but needs approval from a BIP author: @andrewtoth, @RubenSomsen, @theStack WDYT?
jonatack added the label Pending acceptance on Aug 9, 2025
theStack approved
theStack commented at 10:41 PM on August 9, 2025: contributor

ACK 1421be407e93fe364850cace8126553ef19a2406
jonatack removed the label Pending acceptance on Aug 9, 2025
jonatack commented at 9:40 PM on August 10, 2025: member

Thanks @theStack 👍
jonatack merged this on Aug 10, 2025
jonatack closed this on Aug 10, 2025

Contributors

strmfos

jonatack

theStack

Labels

Proposed BIP modification