BIP105: Update to account for BIP34 #194

pull btcdrak wants to merge 1 commits into bitcoin:master from btcdrak:patch-2 changing 1 files +9 −3

btcdrak commented at 9:49 PM on September 5, 2015: contributor

The voting mechanism did not previously account for BIP34.

in bip-0105.mediawiki:None in b13bfc386c outdated

  67 |  
  68 | -The first 4 bytes of the coinbase field shall be repurposed for voting as an
  69 | -unsigned long integer which will be the block size in bytes.
  70 | +As per BIP34, the coinbase transaction scriptSig starts with a serialized 
  71 | +CScript "<< nHeight". The the preferred block size will follow as a push of a 
  72 | +integer in bytes "<< nSizeVote". For example, 0x4c(OP_PUSHDATA1) 0x03(size of constant) 0x80841e(2MB).

luke-jr commented at 11:56 PM on September 5, 2015:

Probably should stick to bytes here to be clear the 2 MB value is signed LE? And you need 4 bytes for this to account for the sign.

sipa commented at 12:20 AM on September 6, 2015:

Also: the the

btcdrak force-pushed on Sep 6, 2015
btcdrak force-pushed on Sep 6, 2015
btcdrak force-pushed on Sep 6, 2015
Update to account for BIP34 f749070a23
btcdrak force-pushed on Sep 6, 2015
luke-jr referenced this in commit 4884b4377a on Sep 19, 2015
luke-jr merged this on Sep 19, 2015
luke-jr closed this on Sep 19, 2015
btcdrak deleted the branch on Sep 20, 2015

Contributors

btcdrak

luke-jr

sipa