bip155: mark torv2 as no longer in use

brunoerg commented at 5:22 pm on September 19, 2025: none

TorV2 is deprecated, implementations are removing any support for it and we could specify this deprecation here. Especially because implementations are no longer serializing/deserializing and relaying Tor v2 addresses, they’re ignoring incoming Tor v2 addresses, etc.

jonatack added the label Proposed BIP modification on Sep 19, 2025

jonatack added the label Pending acceptance on Sep 19, 2025

in bip-0155.mediawiki:104 in e4fd7c37ff

100@@ -101,7 +101,7 @@ The list of reserved network IDs is as follows:
101 | <code>0x03</code>
102 | <code>TORV2</code>
103 | 10
104-| Tor v2 hidden service address
105+| Tor v2 hidden service address (**Deprecated**; clients **MUST NOT** gossip or relay Tor v2 addresses and **MUST** ignore them on receive).

jonatack commented at 5:30 pm on September 19, 2025:

Concept ACK. Didn’t verify, but as I recall Tor v2 was not only deprecated, but no longer supported. Is it still operational?

0| Tor v2 hidden service address (**Tor v2 is no longer operational**; clients **MUST NOT** gossip or relay Tor v2 addresses and **MUST** ignore them on receive).

brunoerg commented at 6:07 pm on September 19, 2025:

You’re right, just changed to it to say “no longer operational”.

jonatack commented at 7:35 pm on September 19, 2025:

Yes, verified that the Tor software no longer supports v2 since July 2021 and the code was removed from the codebase.

brunoerg force-pushed on Sep 19, 2025

jonatack commented at 7:38 pm on September 19, 2025: member

Pinging BIP author @laanwj for feedback or approval.

Not sure if Appendix A about Tor v2 address encoding should be removed or kept for historical context.

jonatack commented at 7:39 pm on September 19, 2025: member

Perhaps a Changelog would be useful here.

brunoerg commented at 3:02 pm on September 25, 2025: none

Not sure if Appendix A about Tor v2 address encoding should be removed or kept for historical context.

Or maybe we could keep it for historical context but change the title to Appendix A: Tor v2 address encoding (Deprecated).

jonatack commented at 4:10 pm on September 25, 2025: member

Maybe Appendix A: Tor v2 address encoding (for historical context, as Tor v2 is no longer operational)

brunoerg force-pushed on Sep 25, 2025

in bip-0155.mediawiki:104 in 278aa42bdc

100@@ -101,7 +101,7 @@ The list of reserved network IDs is as follows:
101 | <code>0x03</code>
102 | <code>TORV2</code>
103 | 10
104-| Tor v2 hidden service address
105+| Tor v2 hidden service address (**Tor v2 is no longer operational**; clients **MUST NOT** gossip or relay Tor v2 addresses and **MUST** ignore them on receive).

laanwj commented at 5:37 pm on September 25, 2025:

It doesn’t look like ** works (the idea was to make bold text, i guess?) in the rendered version. https://github.com/bitcoin/bips/blob/278aa42bdca2824d0e42fbfa4a7167955b08aaf1/bip-0155.mediawiki

Also i wonder if this wouldn’t better be moved to a footnote, instead of having the entire text in the table

E.g. Tor v2 hidden service address (no longer used [1])

[1] Tor v2 is no longer operational; clients MUST NOT gossip or relay Tor v2 addresses and MUST ignore them on receive

murchandamus commented at 10:48 pm on September 29, 2025:

The MediaWiki format uses single quotes to format text as follows: ''italic'', '''bold''', '''''bold & italic'''''.

brunoerg commented at 6:01 pm on October 1, 2025:

Good to know, thanks.

laanwj commented at 5:37 pm on September 25, 2025: member

Concept obvious ACK

murchandamus commented at 10:50 pm on September 29, 2025: contributor

Thanks for the review, @laanwj. @brunoerg: I think adding a Changelog section and moving the majority of the text into a footnote sounds good.

murchandamus added the label PR Author action required on Sep 29, 2025

brunoerg commented at 7:15 pm on September 30, 2025: none

Thanks for the review, @laanwj. @brunoerg: I think adding a Changelog section and moving the majority of the text into a footnote sounds good.

Agreed, will do it.

brunoerg force-pushed on Oct 1, 2025

brunoerg commented at 6:04 pm on October 1, 2025: none

Just moved the text into a footnote (I just noted that some BIPs calls the section that refers to <references/> as References and some others as Footnotes - so I think I put it on the right place) and added a Changelog.

CI failure seems unrelated:

0./typos
1jq: jq-1.7
2$ ./typos .
3Warning: "Falke" should be "False".
4error: `Falke` should be `False`
5    ╭▸ ./bip-0099.mediawiki:355:62
6    │
7355 │ Btcdrak, Gavin Andresen, Gregory Sanders, Luke Dashjr, Marco Falke.

jonatack commented at 7:34 pm on October 1, 2025: member

@brunoerg CI issue is indeed unrelated, fixed in #1996

jonatack closed this on Oct 1, 2025

jonatack reopened this on Oct 1, 2025

in bip-0155.mediawiki:104 in 31158ef92c

100@@ -101,7 +101,7 @@ The list of reserved network IDs is as follows:
101 | <code>0x03</code>
102 | <code>TORV2</code>
103 | 10
104-| Tor v2 hidden service address
105+| Tor v2 hidden service address (no longer used<ref>Tor v2 is no longer operational; clients MUST NOT gossip or relay Tor v2 addresses and MUST ignore them on receive</ref>)

jonatack commented at 7:48 pm on October 1, 2025:

Agree that this information was too long for the table and is better as a footnote.

Should Appendix A also be updated with that info? Seems odd to leave it as-is and have it be contradicted elsewhere in a footnote. What do you think?

brunoerg commented at 11:42 am on October 2, 2025:

I agree it’s odd to leave the Appendix A as is. We could point out there to the same <ref> we introduced before.

brunoerg commented at 11:44 am on October 2, 2025:

Done.

jonatack renamed this:
~~bip155: mark torv2 as deprecated~~
bip155: mark torv2 as no longer in use
on Oct 1, 2025

bip155: torv2 is no longer operational c85c818e3f

bip155: add changelog 0035953ca2

brunoerg force-pushed on Oct 2, 2025

jonatack removed the label PR Author action required on Oct 2, 2025

in bip-0155.mediawiki:155 in 0035953ca2

151@@ -152,7 +152,7 @@ The reference implementation is available at (to be done)
152 
153 - Gregory Maxwell: various suggestions regarding extensibility
154 
155-==Appendix A: Tor v2 address encoding==
156+==Appendix A: Tor v2 address encoding (no longer used <ref name="torv2" />)==

murchandamus commented at 1:00 am on October 3, 2025:

Nit: the space here should be dropped.

0==Appendix A: Tor v2 address encoding (no longer used<ref name="torv2" />)==

murchandamus commented at 1:01 am on October 3, 2025: contributor

Looks good to me.

bip155: drop space before reference cc0db2e8fb

in bip-0155.mediawiki:201 in cc0db2e8fb

192@@ -193,6 +193,13 @@ Cjdns addresses are simply IPv6 addresses in the <code>fc00::/8</code> range<ref
193 
194 Yggdrasil addresses are simply IPv6 addresses in the <code>0200::/7</code> range<ref>[https://yggdrasil-network.github.io/faq.html#will-yggdrasil-conflict-with-my-network-routing Yggdrasil FAQ]</ref>. They MUST be sent with the <code>YGGDRASIL</code> network ID.
195 
196+== Changelog ==
197+
198+* 0.2.0 (2025-10-01):
199+** Add note that Tor v2 is no longer operational.
200+* 0.1.0 (2019-02-27):
201+** Initial version

murchandamus commented at 1:05 am on October 3, 2025:

Actually, per BIP3 which specifies the Changelog section, the initial version should be 1.0.0. And this may well be considered a breaking change of the specification?

jonatack added the label PR Author action required on Oct 6, 2025

bip155: mark torv2 as no longer in use #1975