BIP321: add reference implementation, mention BIP21 replacement #1983

pull jonatack wants to merge 2 commits into bitcoin:master from jonatack:2025-09-BIP321-add-reference-implementation changing 1 files +7 −1
  1. jonatack commented at 4:58 pm on September 24, 2025: member
    • Add Reference Implementation section, using the BIP author’s suggested implementation in #1911 (comment)
    • Mention replacement in addition to modification with respect to BIP21, for consistency with the “Replaces: 21” header
  2. jonatack added the label Proposed BIP modification on Sep 24, 2025
  3. murchandamus added the label Pending acceptance on Sep 29, 2025
  4. in bip-0321.mediawiki:123 in c4acb0877f
    119@@ -120,6 +120,12 @@ For payments completed on-chain, this is largely addressed by having the payment
    120 
    121 In order to avoid inadvertently revealing the sender's IP address or other information to the recipient, proof URIs must only be opened when they will simply switch to another locally-installed application (i.e. the application which initiated the payment). When clicking a URI from a website, the website should already have plenty of logic on its backend to process payment completion and a proof-of-payment callback is unnecessary.
    122 
    123+==Reference Implementation==
    


    murchandamus commented at 11:27 pm on September 29, 2025:

    Consistency nit:

    0== Reference Implementation ==
    

    jonatack commented at 3:47 pm on September 30, 2025:
    I chose this version because it is the most-used one in this repository (though not by a lot).

    murchandamus commented at 3:51 pm on September 30, 2025:
    All other headers in this document use spaces. I don’t care which style is used, but it being the only header formatted differently looks bad.

    jonatack commented at 4:23 pm on September 30, 2025:
    Oh, I see. Updated, thank you.
  5. murchandamus commented at 11:27 pm on September 29, 2025: contributor
    @TheBlueMatt, could you please take a look and sign-off on these two links being the intended content of the Reference Implementation section?
  6. TheBlueMatt commented at 10:08 am on September 30, 2025: contributor
    LGTM, modulo murch’s style note
  7. BIP321: add reference implementation section daf64c4253
  8. BIP321: mention replacement of BIP21
    rather than only modification, for consistency with the "Replaces: 21" header
    c16a33647a
  9. jonatack force-pushed on Sep 30, 2025
  10. jonatack commented at 4:43 pm on September 30, 2025: member
    Thanks @murchandamus and @TheBlueMatt. Updated to take the feedback.
  11. murchandamus commented at 9:34 pm on October 1, 2025: contributor
    ACK, and signed off by Author.
  12. murchandamus merged this on Oct 1, 2025
  13. murchandamus closed this on Oct 1, 2025

  14. jonatack deleted the branch on Oct 1, 2025
  15. murchandamus removed the label Pending acceptance on Oct 11, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-10-12 03:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me