BIP-340: remove unused binascii import from reference.py #1987

pull sky-coderay wants to merge 1 commits into bitcoin:master from sky-coderay:fix/bip340-remove-unused-binascii-import changing 1 files +0 −1
  1. sky-coderay commented at 12:44 pm on September 27, 2025: contributor

    PR Description

    This PR removes an unused import binascii statement from the BIP-340 reference implementation.

    • All test vectors pass (19/19 tests successful)
    • No functional changes to the cryptographic operations
    • The binascii module was imported but never used in the cod
  2. BIP-340: remove unused binascii import from reference.py 2a77c7885a
  3. jonatack added the label Typo-to-be-collected on Sep 28, 2025
  4. jonatack commented at 5:06 pm on September 28, 2025: member
    ACK
  5. theStack approved
  6. theStack commented at 2:41 pm on October 3, 2025: contributor
    ACK 2a77c7885aede8159077db5f94da13c0004f7971
  7. jonatack commented at 7:25 pm on October 3, 2025: member
    Cherry-picked into #1998 (thanks!), so closing here.
  8. jonatack closed this on Oct 3, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-10-12 05:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me