Clarify UTC for all time values in BIP70. #20

pull schildbach wants to merge 1 commits into bitcoin:master from schildbach:bip70-add-utc changing 1 files +3 −3

schildbach commented at 9:27 PM on February 18, 2014: contributor

No description provided.
sipa commented at 9:28 PM on February 18, 2014: member

I don't object to this as a clarification, but it's not really a change. Unix timestamps are always seconds since 1 jan 1970 UTC.
petertodd commented at 9:30 PM on February 18, 2014: contributor

NACK

Unix timestamps are UTC:

Unix time, or POSIX time, is a system for describing instants in time, defined as the number of seconds that have elapsed since 00:00:00 Coordinated Universal Time (UTC), Thursday, 1 January 1970,[note 1] not counting leap seconds.[note 2] It is used widely in Unix-like and many other operating systems and file formats. Due to its handling of leap seconds, it is neither a linear representation of time nor a true representation of UTC.[note 3] Unix time may be checked on most Unix systems by typing date +%s on the command line. -http://en.wikipedia.org/wiki/Unix_time
schildbach commented at 9:42 PM on February 18, 2014: contributor

@petertodd I think it makes still sense as a clarification. The (I believe) first two users of the spec -- apart from the author himself -- got it wrong. I only implemented it correctly by accident.
luke-jr commented at 9:46 PM on February 18, 2014: member

I don't see how one can get this wrong. It shouldn't even be possible to get a Unix-time-like number in another timezone...?

If it's a clarification, it should be the one place inside the parenthesis.
sipa commented at 9:50 PM on February 18, 2014: member

Agree with @luke-jr here.
schildbach commented at 9:53 PM on February 18, 2014: contributor

Ok I moved the UTC into parenthesis.

I also rephrased the third appearence because it wasn't even mentioning unix time (just "system").
petertodd commented at 10:01 PM on February 18, 2014: contributor

Looks reasonable, ACK.
Clarify UTC for all time values in BIP70. 6e7ea85d5c
schildbach commented at 10:07 PM on February 18, 2014: contributor

s/Require/Clarify/ in commit description.
jgarzik commented at 10:21 PM on February 18, 2014: contributor

ACK
gavinandresen referenced this in commit 6f807157a7 on Feb 19, 2014
gavinandresen merged this on Feb 19, 2014
gavinandresen closed this on Feb 19, 2014
laanwj commented at 8:00 AM on February 19, 2014: member

ACK

Maybe what we need here is a reference to the definition of Unix time and the POSIX functions for it, no matter how strange it may sound people seem to not be aware of those (some developers implementing this spec manually implemented functions to count seconds since the epoch in local time?!).
schildbach commented at 8:14 AM on February 19, 2014: contributor

@laanwj Just a side node: As a Java dev, you never get in touch with unix time. All time values are expressed in milliseconds, or other fancy stuff like Date or Calendar objects.
laanwj commented at 8:20 AM on February 19, 2014: member

@schildbach Right, though currentTimeMilis() is really UNIX time but multiplied by a factor 1000. I don't think it gets confused about timezones.
schildbach deleted the branch on Mar 2, 2014
guggero referenced this in commit 67434bc43a on Jun 23, 2022

Contributors