bip-340: set all_passed=False on key generation mismatch #2002
pull MozirDmitriy wants to merge 1 commits into bitcoin:master from MozirDmitriy:fix/bip340-test-harness-keygen-failure-flag changing 1 files +1 −0-
MozirDmitriy commented at 8:38 pm on October 14, 2025: contributorFix test harness to correctly fail when public key generation does not match the expected vector. Previously, the “Failed key generation” branch only printed diagnostics without updating all_passed, leading to a false-positive overall test result. This is a bug because a keygen mismatch indicates an implementation error that must cause the test run to fail, consistent with how other failures in the harness set all_passed = False.
-
bip-340: set all_passed=False on key generation mismatch f98774a68c
-
jonatack commented at 9:19 pm on October 15, 2025: member
ACK f98774a68c23269d9bfa78c8d9c4671ebf4ceb69
Change looks obviously correct and only affects the last line printed in the test output in the case of a test failure.
-
jonatack added the label Bug fix on Oct 15, 2025
-
jonatack commented at 9:25 pm on October 15, 2025: membercc @real-or-random for sign-off
-
real-or-random approved
-
real-or-random commented at 7:07 am on October 16, 2025: contributorutACK f98774a68c23269d9bfa78c8d9c4671ebf4ceb69
-
jonatack merged this on Oct 16, 2025
-
jonatack closed this on Oct 16, 2025
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-10-27 15:10 UTC
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-10-27 15:10 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me