Fix test harness to correctly fail when public key generation does not match the expected vector. Previously, the “Failed key generation” branch only printed diagnostics without updating all_passed, leading to a false-positive overall test result. This is a bug because a keygen mismatch indicates an implementation error that must cause the test run to fail, consistent with how other failures in the harness set all_passed = False.
bip-340: set all_passed=False on key generation mismatch #2002
pull MozirDmitriy wants to merge 1 commits into bitcoin:master from MozirDmitriy:fix/bip340-test-harness-keygen-failure-flag changing 1 files +1 −0-
MozirDmitriy commented at 8:38 PM on October 14, 2025: contributor
-
bip-340: set all_passed=False on key generation mismatch f98774a68c
-
jonatack commented at 9:19 PM on October 15, 2025: member
ACK f98774a68c23269d9bfa78c8d9c4671ebf4ceb69
Change looks obviously correct and only affects the last line printed in the test output in the case of a test failure.
- jonatack added the label Bug fix on Oct 15, 2025
-
jonatack commented at 9:25 PM on October 15, 2025: member
cc @real-or-random for sign-off
- real-or-random approved
-
real-or-random commented at 7:07 AM on October 16, 2025: contributor
utACK f98774a68c23269d9bfa78c8d9c4671ebf4ceb69
- jonatack merged this on Oct 16, 2025
- jonatack closed this on Oct 16, 2025
Contributors
Labels