bip-373: Fix GLOBAL_XPUB key name and clean up compressed vs x-only note #2007

pull Galoretka wants to merge 2 commits into bitcoin:master from Galoretka:fix/bip373-global-xpub-and-note changing 1 files +3 −3

Galoretka commented at 12:29 PM on October 16, 2025: contributor

Replaced incorrect PSBT key name PSBT_IN_GLOBAL_XPUB with the canonical PSBT_GLOBAL_XPUB (per BIP 174). This corrects scope naming (GLOBAL vs per-input) and aligns with existing PSBT specifications. Removed duplicated/garbled sentence and punctuation in the reference note explaining why compressed pubkeys are used instead of x-only. The note now clearly states the evenness-byte requirement and fingerprint rationale without repetition.
bip-373: Fix GLOBAL_XPUB key name and clean up compressed vs x-only note d175b46bbf
jonatack added the label Typo-to-be-collected on Oct 17, 2025

jonatack commented at 6:23 PM on October 17, 2025: member

ACK, nice fixups. Maybe optionally add this while here.

--- a/bip-0373.mediawiki
+++ b/bip-0373.mediawiki
@@ -9,13 +9,14 @@
   Type: Standards Track
   Created: 2024-06-04
   License: CC0-1.0
+  Requires: 32, 174, 327, 328, 370
 </pre>

achow101 commented at 7:11 PM on December 8, 2025: member

ACK d175b46bbf1d3a8a294b8bb76d79c5ee33e8dd7e
add requires 0b3ab94fb7
Galoretka commented at 6:26 AM on December 9, 2025: contributor
+ Requires: 32, 174, 327, 328, 370
Oh, forgot about it, added
murchandamus commented at 4:32 PM on December 9, 2025: contributor

ACK 0b3ab94fb7173e385c45bb0d91c3a0a07aae3788
murchandamus merged this on Dec 9, 2025
murchandamus closed this on Dec 9, 2025
murchandamus removed the label Typo-to-be-collected on Dec 9, 2025

Contributors