BIP-328: rename point_mul parameter to scalar in xpub.py to avoid shadowing n #2013

pull GarmashAlex wants to merge 1 commits into bitcoin:master from GarmashAlex:fix/xpub-point-mul-scalar-param changing 1 files +2 −2

GarmashAlex commented at 9:31 am on October 20, 2025: contributor

Problem: The point_mul function in bip-0328/_xpub.py used a parameter named n, shadowing the global curve order n. The global n is currently unused in this file, making it dead code and creating confusion. Fix: Renamed the point_mul parameter to scalar and updated internal references to remove shadowing and improve clarity, preparing the module for future BIP32 range checks that will use the global n. No changes were made to BIP reference files where this naming is intentional.
BIP-328: rename point_mul parameter to scalar in xpub.py to avoid shadowing n c31e311b58
murchandamus commented at 1:43 pm on October 21, 2025: contributor

This is not a meaningful improvement. Please do not open trivial PRs to this repository. LLM use is explicitly unwelcome in this repository.
murchandamus closed this on Oct 21, 2025