BIP324: Fix features bitmask for decoding-case selection #2016

pull real-or-random wants to merge 2 commits into bitcoin:master from real-or-random:202510-fix-gen-test-vectors changing 2 files +10 −10
  1. real-or-random commented at 12:16 pm on October 23, 2025: contributor

    Superseeds #1969. On top of #1969.

    I’m one of the authors of BIP324 but let’s wait for an ACK from @sipa, please.

  2. real-or-random force-pushed on Oct 23, 2025
  3. BIP324: Fix features bitmask for decoding-case selection d51f2dcaeb
  4. bip324: Update generated files 713f000a20
  5. real-or-random force-pushed on Oct 23, 2025
  6. jonatack added the label Proposed BIP modification on Oct 23, 2025
  7. jonatack added the label Pending acceptance on Oct 23, 2025
  8. jonatack commented at 8:41 pm on October 23, 2025: member

    ACK 713f000a20421a54b29cd8ab89e711eef1fbccb9

    The first commit is the same as the change I previously reviewed and ACKed in #1969, but I didn’t previously verify by re-generating the test vectors, which generates the diff we see in the second commit. Re-verified the second commit by running gen_test_vectors.py on it and seeing no change, and ran run_test_vectors.py to sanity-check that the tests pass.

  9. sipa commented at 10:49 pm on October 23, 2025: member
    ACK code changes; I did not verify the generated output.
  10. jonatack removed the label Pending acceptance on Oct 23, 2025
  11. real-or-random marked this as ready for review on Oct 24, 2025
  12. real-or-random commented at 6:12 am on October 24, 2025: contributor
    Ready for merge then :)
  13. jonatack merged this on Oct 24, 2025
  14. jonatack closed this on Oct 24, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-10-27 15:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me