Context: bip-0328/reference.py imported xpub_to_pub_hex, but the symbol is never used; this triggers lint warnings and adds noise to reviews. Change: Drop the unused _base58.xpub_to_pub_hex import so the module only depends on what it actually uses. Testing: python bip-0328/reference.py (blocked locally: Python runtime not available in the environment, behavior unaffected by import cleanup)
Remove unused import in bip-0328 reference script #2030
pull Doryu001 wants to merge 1 commits into bitcoin:master from Doryu001:patch-2 changing 1 files +0 −1-
Doryu001 commented at 8:43 PM on November 3, 2025: none
-
Update reference.py 8dc7e2503b
- jonatack added the label Typo-to-be-collected on Nov 3, 2025
-
jonatack commented at 9:09 PM on November 4, 2025: member
ACK
We'll batch this into a monthly cleanup that will credit you as author (thanks!)
- jonatack closed this on Nov 4, 2025
Labels