BIP-128: Exact specification for the checksum calculation #2121

pull oren-z0 wants to merge 1 commits into bitcoin:master from oren-z0:bip-128-specify-checksum-calculation changing 1 files +11 −2
  1. oren-z0 commented at 7:48 pm on March 13, 2026: contributor
    The checksum calculation should be consistent in all implementations.
  2. murchandamus added the label BIP update by author on Mar 13, 2026
  3. in bip-0128.mediawiki:160 in e1c20ac2ac
    155@@ -156,8 +156,17 @@ The checksum is calculated by converting the top-level JSON object to an array o
    156 SHA256 hash of the result in lowercase hexadecimal format, and taking a prefix of at least 8
    157 characters.
    158 
    159-For example:
    160+"stringifying" in this context means converting the array to a JSON string following
    161+ECAMScript's JSON.stringify function specification (without additional <code>replacer</code>
    


    murchandamus commented at 8:03 pm on March 13, 2026:
    0ECMAScript's JSON.stringify function specification (without additional <code>replacer</code>
    

    This could also perhaps use a link to that specification.


    oren-z0 commented at 8:19 pm on March 13, 2026:
    Done, added a link as well.

    oren-z0 commented at 8:32 pm on March 13, 2026:
    I also noticed that https://bips.dev doesn’t interpret the mediawiki file correctly, and breaks on <code>[key, value]</code>. The website thinks the [ is the beginning of a link or something.

    murchandamus commented at 11:40 pm on March 13, 2026:
    Both bips.xyz and bips.dev are unaffiliated projects, but I’ve had success with opening issues on their github repositories. This one is bips.dev: https://github.com/nickmonad/bips.dev/issues
  4. murchandamus commented at 8:04 pm on March 13, 2026: member
    Looks mostly reasonable. I have one typo for you. Is there anyone else that should be reviewing this? If not, perhaps you, in a couple days? :)
  5. oren-z0 force-pushed on Mar 13, 2026
  6. oren-z0 force-pushed on Mar 13, 2026
  7. BIP-128: exact specification for the checksum calculation 9441e39e92
  8. oren-z0 force-pushed on Mar 14, 2026
  9. murchandamus commented at 6:25 pm on March 16, 2026: member
    LGTM
  10. murchandamus merged this on Mar 16, 2026
  11. murchandamus closed this on Mar 16, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-23 05:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me