BIP-174: mark PSBT_GLOBAL_VERSION as required for v2 #2127

pull theStack wants to merge 1 commits into bitcoin:master from theStack:bip174-global_version-mandatory-in-v2 changing 1 files +1 −1
  1. theStack commented at 3:55 pm on March 20, 2026: contributor
    This PR adds version 2 to the “Versions Requiring Inclusion” column (currently empty) for the PSBT_GLOBAL_VERSION field. See BIP-370: https://github.com/bitcoin/bips/blob/2778442c21cef2290ae3e0c843d9f3179aa1cdd0/bip-0370.mediawiki?plain=1#L41
  2. BIP-174: mark PSBT_GLOBAL_VERSION as required for v2 fa731d21c4
  3. in bip-0174.mediawiki:197 in fa731d21c4
    nymius commented at 5:41 pm on March 20, 2026:

    I’m not sure we can make this change. It seems PSBT_GLOBAL_VERSION is a different key on each version.

    Do you know why the name of the field is the same in both BIPs, but for BIP 370 the keytype for PSBT_GLOBAL_VERSION is 0x02 and for BIP 174 the PSBT_GLOBAL_VERSION keytype is 0xFB? What are we missing here?

    achow101 commented at 5:45 pm on March 20, 2026:
    They’re different fields. It’s PSBT_GLOBAL_TX_VERSION in 370, which is not the same as PSBT_GLOBAL_VERSION.
    theStack commented at 5:46 pm on March 20, 2026:

    I’m not sure we can make this change. It seems PSBT_GLOBAL_VERSION is a different key on each version.

    Do you know why the name of the field is the same in both BIPs, but for BIP 370 the keytype for PSBT_GLOBAL_VERSION is 0x02 and for BIP 174 the PSBT_GLOBAL_VERSION keytype is 0xFB? What are we missing here?

    Ah that’s indeed confusing. Note that the field in the BIP370 table is PSBT_GLOBAL_TX_VERSION (0x02) and denotes the transaction’s version, while PSBT_GLOBAL_VERSION (0xFB, not explicitly defined in BIP370) denotes the PSBT version.

    // EDIT: @achow101 was faster :)

  4. achow101 commented at 5:46 pm on March 20, 2026: member
    ACK
  5. murchandamus added the label Proposed BIP modification on Mar 23, 2026
  6. murchandamus merged this on Mar 23, 2026
  7. murchandamus closed this on Mar 23, 2026
  8. murchandamus commented at 6:39 pm on March 23, 2026: member
    It would be good if a Changelog section were added to BIP 174
  9. theStack deleted the branch on Mar 23, 2026


theStack nymius achow101 murchandamus

Labels
Proposed BIP modification

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-24 00:10 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me