This PR helps clarify some language used in BIP-54
BIP 54: grammar improvements #2151
pull nervana21 wants to merge 5 commits into bitcoin:master from nervana21:20260406_bip54_clarity changing 1 files +10 −12-
nervana21 commented at 10:38 AM on May 6, 2026: contributor
-
bip54: Clarify deployment cost wording 9409c942a7
-
bip54: Clarify merkle tree wording 353b6a8f82
-
bip54: Clarify sigops wording d61f45da2e
-
bip54: Clarify timewarp wording 29c0675d4c
-
bip54: Clarify miner preparation cost wording af954ff08e
- murchandamus added the label Proposed BIP modification on May 6, 2026
- murchandamus added the label Pending acceptance on May 6, 2026
-
murchandamus commented at 12:17 PM on May 6, 2026: member
cc: @darosior for review
-
in bip-0054.md:90 in af954ff08e
86 | @@ -88,25 +87,24 @@ the timewarp and Murch–Zawy vulnerabilities[^3]. The latter poses mostly theor 87 | extremely low risk to fix: the duration of an adjustment period has never been, and should never be, 88 | negative. The former is fixed by preventing the timestamp of the first block of a difficulty period 89 | from being lower than the previous block's, with a two-hour grace period. A [previous 90 | -proposal][BIP-XXXX] to fix timewarp used a ten-minute grace period instead, also adopted for 91 | -[testnet4][BIP94 timewarp]. Out of an abundance of caution and because it only trivially worsens the 92 | +proposal][BIP-XXXX] to fix the timewarp attack used a ten-minute grace period instead, and this
murchandamus commented at 12:18 PM on May 6, 2026:The first link here seems to be a dead link. Should that be dropped, @darosior?
jonatack commented at 5:07 PM on May 6, 2026:IIUC per line 230 below it is intended to be a link to https://github.com/TheBlueMatt/bips/blob/7f9670b643b7c943a0cc6d2197d3eabe661050c2/bip-XXXX.mediawiki
jonatack commented at 5:08 PM on May 6, 2026:(There are two other similar links below in this BIP; all 3 work for me.)
murchandamus commented at 8:42 AM on May 7, 2026:Oops, my bad. I recant. I thought that BIP-XXXX was a provisional placeholder and didn’t realize that it was just defined below.
jonatack renamed this:20260406 bip54 clarity
BIP 54: grammar improvements
on May 6, 2026in bip-0054.md:107 in 353b6a8f82
102 | @@ -103,9 +103,8 @@ increases the preparation cost of an attack to make it uneconomical for a miner[ 103 | invalid[^7]. 104 | 105 | In the presence of 64-byte transactions a block header's Merkle root may be valid for different sets 106 | -of transactions. This is because in the Merkle tree construction a 64-byte transaction may be 107 | -interpreted as the catenation of two 32-byte hashes, or the catenation of two 32-byte hashes may be 108 | -interpreted as a transaction. The former allows to fake a block inclusion proof and the latter makes 109 | +of transactions. This is because, in the Merkle tree construction, a 64-byte value may be 110 | +interpreted either as a transaction or as the concatenation of two 32-byte hashes. The former allows faking a block inclusion proof and the latter makes
darosior commented at 9:45 AM on May 7, 2026:English newbie question: why prefer "concatenation" to "catenation"? Isn't it just more letter for the very same meaning? Is it simply that it's more natural to use the longer word?
murchandamus commented at 10:21 AM on May 7, 2026:They’re synonyms, but concatenation is the standard term in computer science and much more commonly used (maybe about a magnitude more often).
nervana21 commented at 10:23 AM on May 7, 2026:TIL! I hadn't previously known that "catenation" was a word!
darosior approveddarosior commented at 9:48 AM on May 7, 2026: memberACK af954ff08e7e950eae1dc3b890d61410e56fd833
Thank you.
murchandamus commented at 10:22 AM on May 7, 2026: memberLGTM, and signed off by BIP Owner.
Thanks, @nervana21 for the improvements, thanks for the quick turnaround, @darosior.
murchandamus removed the label Pending acceptance on May 7, 2026murchandamus merged this on May 7, 2026murchandamus closed this on May 7, 2026nervana21 deleted the branch on May 7, 2026Contributors
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-09 19:10 UTC
More mirrored repositories can be found on mirror.b10c.me