bip1: Record close reason #2167

pull murchandamus wants to merge 1 commits into bitcoin:master from murchandamus:bip1-record-close-reason changing 1 files +6 −3

murchandamus commented at 12:45 AM on May 21, 2026: member

This commit forgoes introducing a version, as the BIP has been closed for a decade and it is no longer necessary to update the readers regarding specification changes of BIP1.

bip1: Record close reason

This commit forgoes introducing a version, as the BIP has been closed
for a decade and it is no longer necessary to update the readers
regarding specification changes of BIP1.

92d5ce5684

murchandamus added the label Metadata Update on May 21, 2026
jonatack commented at 3:00 PM on May 21, 2026: member

ACK, modulo that #478 updated BIP 1 from Active to Replaced, and then 66defbdc0 updated BIP 1 from Replaced to Closed. Do you think it is worth describing this with separate changelog entries? I think it may be clearer to readers.

in bip-0001.mediawiki:180 in 92d5ce5684

 176 | @@ -177,6 +177,9 @@ This document was derived heavily from Python's PEP-0001. In many places text wa
 177 |  
 178 |  ==Changelog==
 179 |  
 180 | -10 Oct 2015 - Added clarifications about submission process and BIP number assignment.
 181 | -
 182 | -01 Jan 2016 - Clarified early stages of BIP idea championing, collecting community feedback, etc.
 183 | +* 2016-12-14:

jonatack commented at 3:07 PM on May 21, 2026:

Indeed, corresponds to the date #478 was merged.

murchandamus commented at 4:33 PM on May 21, 2026: member

ACK, modulo that #478 updated BIP 1 from Active to Replaced, and then 66defbd updated BIP 1 from Replaced to Closed. Do you think it is worth describing this with separate changelog entries? I think it may be clearer to readers.

I don’t think that it adds value to record the Deployment of BIP3 in every closed BIP’s Changelog. Therefore, my preferred approach would be to fold the update to Closed into the Changelog entry that records the original closure, while recording the close reason in that context to reflect what status update was made originally. In this case, "superseded" conveys that BIP1 was replaced.
jonatack merged this on May 21, 2026
jonatack closed this on May 21, 2026
jonatack commented at 4:55 PM on May 21, 2026: member

While it seems somewhat more true to history to record the change, it's not a strong opinion and point taken.

Contributors

murchandamus

jonatack

Labels

Metadata Update